From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33112)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1Xz3U3-0002VZ-7c
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 08:09:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1Xz3Sk-0008Lg-KK
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 08:08:43 -0500
Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:53122 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1Xz3Sk-0008Ih-Ai
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 08:07:22 -0500
Message-ID: <54899702.1040500@kamp.de>
Date: Thu, 11 Dec 2014 14:07:14 +0100
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1418142410-19057-1-git-send-email-pl@kamp.de>
	<1418142410-19057-5-git-send-email-pl@kamp.de>
	<20141210074806.GB32726@ad.nay.redhat.com>
In-Reply-To: <20141210074806.GB32726@ad.nay.redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/4] virtio-blk: introduce multiread
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, benoit@irqsave.net, ming.lei@canonical.com, armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, mreitz@redhat.com

On 10.12.2014 08:48, Fam Zheng wrote:
> On Tue, 12/09 17:26, Peter Lieven wrote:
>> diff --git a/include/hw/virtio/virtio-blk.h b/include/hw/virtio/virtio-blk.h
>> index 3f2652f..0ee9582 100644
>> --- a/include/hw/virtio/virtio-blk.h
>> +++ b/include/hw/virtio/virtio-blk.h
>> @@ -134,13 +134,6 @@ typedef struct VirtIOBlock {
>>       struct VirtIOBlockDataPlane *dataplane;
>>   } VirtIOBlock;
>>   
>> -#define VIRTIO_BLK_MAX_MERGE_REQS 32
>> -
>> -typedef struct MultiReqBuffer {
>> -    BlockRequest        blkreq[VIRTIO_BLK_MAX_MERGE_REQS];
>> -    unsigned int        num_writes;
>> -} MultiReqBuffer;
>> -
>>   typedef struct VirtIOBlockReq {
>>       VirtIOBlock *dev;
>>       VirtQueueElement elem;
>> @@ -149,8 +142,21 @@ typedef struct VirtIOBlockReq {
>>       QEMUIOVector qiov;
>>       struct VirtIOBlockReq *next;
>>       BlockAcctCookie acct;
>> +    QEMUIOVector mr_qiov;
>> +    struct VirtIOBlockReq *mr_next;
>>   } VirtIOBlockReq;
>>   
>> +#define MAX_MERGE_REQS 32
> Why do you need to rename this macro after introducing it in previous patch?

Right ;-)

This was the orgininal name and I changed it later in Patch 2 by request.

Waiting for other feedback in will change it in a next revision.

Peter