qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] hw/arm/smmuv3: Fix up L1STD_SPAN decoding
@ 2020-11-24  2:37 Kunkun Jiang
  2020-11-28  9:07 ` Kunkun Jiang
  2020-11-30 11:29 ` Peter Maydell
  0 siblings, 2 replies; 4+ messages in thread
From: Kunkun Jiang @ 2020-11-24  2:37 UTC (permalink / raw)
  To: Eric Auger, Peter Maydell, open list:ARM SMMU,
	open list:All patches CC here
  Cc: wanghaibin.wang, Kunkun Jiang, Keqian Zhu

Accroding to the SMMUv3 spec, the SPAN field of Level1 Stream Table
Descriptor is 5 bits([4:0]).

Fixes: 9bde7f0674f(hw/arm/smmuv3: Implement translate callback)
Signed-off-by: Kunkun Jiang <jiangkunkun@huawei.com>
---
 hw/arm/smmuv3-internal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/arm/smmuv3-internal.h b/hw/arm/smmuv3-internal.h
index fa3c088972..b6f7e53b7c 100644
--- a/hw/arm/smmuv3-internal.h
+++ b/hw/arm/smmuv3-internal.h
@@ -633,6 +633,6 @@ static inline uint64_t l1std_l2ptr(STEDesc *desc)
     return hi << 32 | lo;
 }
 
-#define L1STD_SPAN(stm) (extract32((stm)->word[0], 0, 4))
+#define L1STD_SPAN(stm) (extract32((stm)->word[0], 0, 5))
 
 #endif
-- 
2.23.0



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] hw/arm/smmuv3: Fix up L1STD_SPAN decoding
  2020-11-24  2:37 [PATCH] hw/arm/smmuv3: Fix up L1STD_SPAN decoding Kunkun Jiang
@ 2020-11-28  9:07 ` Kunkun Jiang
  2020-11-30 11:29 ` Peter Maydell
  1 sibling, 0 replies; 4+ messages in thread
From: Kunkun Jiang @ 2020-11-28  9:07 UTC (permalink / raw)
  To: Eric Auger, Peter Maydell, qemu-arm, qemu-devel
  Cc: wanghaibin.wang, Keqian Zhu

Hi Eric,

Friendly ping... :)

On 2020/11/24 10:37, Kunkun Jiang wrote:
> Accroding to the SMMUv3 spec, the SPAN field of Level1 Stream Table
> Descriptor is 5 bits([4:0]).
>
> Fixes: 9bde7f0674f(hw/arm/smmuv3: Implement translate callback)
> Signed-off-by: Kunkun Jiang <jiangkunkun@huawei.com>
> ---
>   hw/arm/smmuv3-internal.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/smmuv3-internal.h b/hw/arm/smmuv3-internal.h
> index fa3c088972..b6f7e53b7c 100644
> --- a/hw/arm/smmuv3-internal.h
> +++ b/hw/arm/smmuv3-internal.h
> @@ -633,6 +633,6 @@ static inline uint64_t l1std_l2ptr(STEDesc *desc)
>       return hi << 32 | lo;
>   }
>   
> -#define L1STD_SPAN(stm) (extract32((stm)->word[0], 0, 4))
> +#define L1STD_SPAN(stm) (extract32((stm)->word[0], 0, 5))
>   
>   #endif

Thanks,

Kunkun Jiang



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] hw/arm/smmuv3: Fix up L1STD_SPAN decoding
  2020-11-24  2:37 [PATCH] hw/arm/smmuv3: Fix up L1STD_SPAN decoding Kunkun Jiang
  2020-11-28  9:07 ` Kunkun Jiang
@ 2020-11-30 11:29 ` Peter Maydell
  2020-11-30 13:06   ` Auger Eric
  1 sibling, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2020-11-30 11:29 UTC (permalink / raw)
  To: Kunkun Jiang
  Cc: Eric Auger, open list:ARM SMMU, Keqian Zhu,
	open list:All patches CC here, wanghaibin.wang

On Tue, 24 Nov 2020 at 02:37, Kunkun Jiang <jiangkunkun@huawei.com> wrote:
>
> Accroding to the SMMUv3 spec, the SPAN field of Level1 Stream Table
> Descriptor is 5 bits([4:0]).
>
> Fixes: 9bde7f0674f(hw/arm/smmuv3: Implement translate callback)
> Signed-off-by: Kunkun Jiang <jiangkunkun@huawei.com>
> ---


Applied to target-arm.next for 6.0, thanks.

-- PMM


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] hw/arm/smmuv3: Fix up L1STD_SPAN decoding
  2020-11-30 11:29 ` Peter Maydell
@ 2020-11-30 13:06   ` Auger Eric
  0 siblings, 0 replies; 4+ messages in thread
From: Auger Eric @ 2020-11-30 13:06 UTC (permalink / raw)
  To: Peter Maydell, Kunkun Jiang
  Cc: wanghaibin.wang, open list:ARM SMMU, Keqian Zhu,
	open list:All patches CC here

Hi Kunkun, Peter,

On 11/30/20 12:29 PM, Peter Maydell wrote:
> On Tue, 24 Nov 2020 at 02:37, Kunkun Jiang <jiangkunkun@huawei.com> wrote:
>>
>> Accroding to the SMMUv3 spec, the SPAN field of Level1 Stream Table
>> Descriptor is 5 bits([4:0]).
>>
>> Fixes: 9bde7f0674f(hw/arm/smmuv3: Implement translate callback)
>> Signed-off-by: Kunkun Jiang <jiangkunkun@huawei.com>
>> ---
Acked-by: Eric Auger <eric.auger@redhat.com>
> 
> 
> Applied to target-arm.next for 6.0, thanks.
thanks and sorry for the delay

Eric
> 
> -- PMM
> 



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-11-30 13:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-24  2:37 [PATCH] hw/arm/smmuv3: Fix up L1STD_SPAN decoding Kunkun Jiang
2020-11-28  9:07 ` Kunkun Jiang
2020-11-30 11:29 ` Peter Maydell
2020-11-30 13:06   ` Auger Eric

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).