From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz4Mp-0002Bo-Qu for qemu-devel@nongnu.org; Thu, 11 Dec 2014 09:05:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xz4Mj-0006AZ-Mi for qemu-devel@nongnu.org; Thu, 11 Dec 2014 09:05:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz4Mj-0006AU-F2 for qemu-devel@nongnu.org; Thu, 11 Dec 2014 09:05:13 -0500 Message-ID: <5489A495.1040806@redhat.com> Date: Thu, 11 Dec 2014 15:05:09 +0100 From: Max Reitz MIME-Version: 1.0 References: <1418294973-21790-1-git-send-email-kraxel@redhat.com> <1418294973-21790-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1418294973-21790-2-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/10] sdl: move version logic from source code to makefile List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: Anthony Liguori On 2014-12-11 at 11:49, Gerd Hoffmann wrote: > Compile sdl.c / sdl2.c depending on CONFIG_SDLABI instead of > compiling both and have version #ifdefs in the source code. > > Signed-off-by: Gerd Hoffmann > --- > ui/Makefile.objs | 7 ++++++- > ui/sdl.c | 3 --- > ui/sdl2.c | 3 --- > 3 files changed, 6 insertions(+), 7 deletions(-) Reviewed-by: Max Reitz