From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz6d6-0004Fg-It for qemu-devel@nongnu.org; Thu, 11 Dec 2014 11:30:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xz6cw-0005tK-HF for qemu-devel@nongnu.org; Thu, 11 Dec 2014 11:30:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53638) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz6cw-0005qx-9H for qemu-devel@nongnu.org; Thu, 11 Dec 2014 11:30:06 -0500 Message-ID: <5489B5C8.5090500@redhat.com> Date: Thu, 11 Dec 2014 08:18:32 -0700 From: Eric Blake MIME-Version: 1.0 References: <1418307457-25996-1-git-send-email-vsementsov@parallels.com> <1418307457-25996-9-git-send-email-vsementsov@parallels.com> In-Reply-To: <1418307457-25996-9-git-send-email-vsementsov@parallels.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UVjMfsgmgpEiN4MMxTQB5envpwTU2CVJt" Subject: Re: [Qemu-devel] [PATCH 8/9] migration: add dirty parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Cc: kwolf@redhat.com, den@openvz.org, jsnow@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UVjMfsgmgpEiN4MMxTQB5envpwTU2CVJt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/11/2014 07:17 AM, Vladimir Sementsov-Ogievskiy wrote: > Add dirty parameter to qmp-migrate command. If this parameter is true, > block-migration.c will migrate dirty bitmaps. This parameter can be use= d > without "blk" parameter to migrate only dirty bitmaps, skipping block > migration. >=20 > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > +++ b/qapi-schema.json > @@ -1660,7 +1660,7 @@ > # Since: 0.14.0 > ## > { 'command': 'migrate', > - 'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*detach': 'b= ool' } } > + 'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*dirty': 'bo= ol', '*detach': 'bool' } } Missing documentation of the new option (including a mention of '(since 2.3)'. Also, please keep lines shorter than 80 columns. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UVjMfsgmgpEiN4MMxTQB5envpwTU2CVJt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUibXIAAoJEKeha0olJ0NqQ1IH/izWWtbMA5y+uUHCFaypNc7c VK2mqCBbtTn1jayVF026ndCAGwLatAIM0NrymXsEzr5LgX+4u7p2MB7Fw8e1xV+c ueuCjGgOBgGEiwCk3/y8SHsnG70M8zvB8VN9uEJkAL3c0ywyYeqk2EgBdDkqXklt hZejpaQj0TgwbCg9b3PPkNtjOeIcE/gLShuW2wW8vOOFJwEiiWAx9sPysMNKle8q FFS74e5EyNqeWVglRJ4xVxEhUzT8oD5X2ks2aq6KnYWUV6TBWAMFQL96unTypJlv 5nh1SX99F5/4Frpm6wlQVJe09ebMuiELhViFkdNPO7uvyGuzM/eMtA/8zU1K3E8= =HcaE -----END PGP SIGNATURE----- --UVjMfsgmgpEiN4MMxTQB5envpwTU2CVJt--