From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz5XC-000188-IK for qemu-devel@nongnu.org; Thu, 11 Dec 2014 10:20:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xz5X6-0007tk-K7 for qemu-devel@nongnu.org; Thu, 11 Dec 2014 10:20:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz5X6-0007sl-4H for qemu-devel@nongnu.org; Thu, 11 Dec 2014 10:20:00 -0500 Message-ID: <5489B61B.6000807@redhat.com> Date: Thu, 11 Dec 2014 16:19:55 +0100 From: Max Reitz MIME-Version: 1.0 References: <1418294973-21790-1-git-send-email-kraxel@redhat.com> <1418294973-21790-11-git-send-email-kraxel@redhat.com> In-Reply-To: <1418294973-21790-11-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/10] sdl2: move sdl2_2d_refresh to sdl2-2d.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: Anthony Liguori On 2014-12-11 at 11:49, Gerd Hoffmann wrote: > Now that common event handling code is split off, we can move > over sdl_refresh to sdl2-2d.c, and rename it to sdl2_2d_refresh. > > Signed-off-by: Gerd Hoffmann > --- > include/ui/sdl2.h | 1 + > ui/sdl2-2d.c | 9 +++++++++ > ui/sdl2.c | 10 +--------- > 3 files changed, 11 insertions(+), 9 deletions(-) > > diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h > index 27b3132..9e9a92d 100644 > --- a/include/ui/sdl2.h > +++ b/include/ui/sdl2.h > @@ -23,4 +23,5 @@ void sdl2_2d_update(DisplayChangeListener *dcl, > int x, int y, int w, int h); > void sdl2_2d_switch(DisplayChangeListener *dcl, > DisplaySurface *new_surface); > +void sdl2_2d_refresh(DisplayChangeListener *dcl); > void sdl2_2d_redraw(struct sdl2_console *scon); > diff --git a/ui/sdl2-2d.c b/ui/sdl2-2d.c > index 40a552c..9c60075 100644 > --- a/ui/sdl2-2d.c > +++ b/ui/sdl2-2d.c > @@ -103,6 +103,15 @@ void sdl2_2d_switch(DisplayChangeListener *dcl, > sdl2_2d_redraw(scon); > } > > +void sdl2_2d_refresh(DisplayChangeListener *dcl) > +{ > + struct sdl2_console *scon = container_of(dcl, struct sdl2_console, dcl); > + > + assert(!scon->opengl); This doesn't compile for me because this flag is not added by this series. With this assertion moved to the OpenGL series: Reviewed-by: Max Reitz