From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51239)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1Xz5oe-0008LS-BC
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 10:38:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1Xz5oU-0008HY-K9
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 10:38:08 -0500
Received: from mailapp01.imgtec.com ([195.59.15.196]:43908)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1Xz5oU-0008HK-Cj
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 10:37:58 -0500
Message-ID: <5489BA55.1000004@imgtec.com>
Date: Thu, 11 Dec 2014 15:37:57 +0000
From: Leon Alrae <leon.alrae@imgtec.com>
MIME-Version: 1.0
References: <alpine.DEB.1.10.1412022227360.19155@tp.orcam.me.uk>
In-Reply-To: <alpine.DEB.1.10.1412022227360.19155@tp.orcam.me.uk>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-mips: Fix DisasContext's ulri
	member initialization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Maciej W. Rozycki" <macro@codesourcery.com>, qemu-devel@nongnu.org
Cc: Aurelien Jarno <aurelien@aurel32.net>

On 02/12/2014 22:31, Maciej W. Rozycki wrote:
> Set DisasContext's ulri member to 0 or 1 as with other bool members.
> 
> Signed-off-by: Maciej W. Rozycki <macro@codesourcery.com>
> ---
> qemu-mips-disas-ulri.diff
> Index: qemu-git-trunk/target-mips/translate.c
> ===================================================================
> --- qemu-git-trunk.orig/target-mips/translate.c	2014-12-02 21:28:17.528936640 +0000
> +++ qemu-git-trunk/target-mips/translate.c	2014-12-02 21:28:41.028928249 +0000
> @@ -19114,7 +19114,7 @@ gen_intermediate_code_internal(MIPSCPU *
>      ctx.bp = (env->CP0_Config3 >> CP0C3_BP) & 1;
>      /* Restore delay slot state from the tb context.  */
>      ctx.hflags = (uint32_t)tb->flags; /* FIXME: maybe use 64 bits here? */
> -    ctx.ulri = env->CP0_Config3 & (1 << CP0C3_ULRI);
> +    ctx.ulri = (env->CP0_Config3 >> CP0C3_ULRI) & 1;
>      restore_cpu_state(env, &ctx);
>  #ifdef CONFIG_USER_ONLY
>          ctx.mem_idx = MIPS_HFLAG_UM;
> 

Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>