From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: "Alex Züpke" <alexander.zuepke@hs-rm.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v1 1/1] target-tricore: fix offset masking in BOL format + typo
Date: Fri, 12 Dec 2014 13:20:52 +0000 [thread overview]
Message-ID: <548AEBB4.8070907@mail.uni-paderborn.de> (raw)
In-Reply-To: <548AC2A4.6010009@hs-rm.de>
On 12/12/2014 10:25 AM, Alex Züpke wrote:
> Fixes offset masking for BOL opcodes and a typo (LONF -> LONG)
>
> Signed-off-by: Alex Zuepke <alexander.zuepke@hs-rm.de>
Hi Alex,
good catch. I wonder how that slipped through my testsuit. However you
mail seems to be malformed. The patch went somehow into your signature.
Don't do that, please. It is easier for the reviewer and you, if he can
inline comments to the corresponding line, he wants to talk about. Also
you don't need a v1 for the first version of a patch and please group up
similar patches, e.g. for tricore.
The usual workflow with git would be, for your two patches:
1) git format-patch -2 --cover-letter
2) edit coverletter and say, what the patches are doing.
3) git send-email --to="qemu-devel@nongnu.org" --cc=... *.patch
Other than that, it looks good to me. If you resend your two patches
well formated, I'll add them to my tricore-next branch.
Cheers,
Bastian
prev parent reply other threads:[~2014-12-12 12:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 10:25 [Qemu-devel] [PATCH v1 1/1] target-tricore: fix offset masking in BOL format + typo Alex Züpke
2014-12-12 13:20 ` Bastian Koppelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548AEBB4.8070907@mail.uni-paderborn.de \
--to=kbastian@mail.uni-paderborn.de \
--cc=alexander.zuepke@hs-rm.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).