From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzPDC-00058g-PH for qemu-devel@nongnu.org; Fri, 12 Dec 2014 07:20:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzPD6-0003hU-VO for qemu-devel@nongnu.org; Fri, 12 Dec 2014 07:20:46 -0500 Received: from mail.uni-paderborn.de ([131.234.142.9]:57239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzPD6-0003gX-E2 for qemu-devel@nongnu.org; Fri, 12 Dec 2014 07:20:40 -0500 Message-ID: <548AEBB4.8070907@mail.uni-paderborn.de> Date: Fri, 12 Dec 2014 13:20:52 +0000 From: Bastian Koppelmann MIME-Version: 1.0 References: <548AC2A4.6010009@hs-rm.de> In-Reply-To: <548AC2A4.6010009@hs-rm.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v1 1/1] target-tricore: fix offset masking in BOL format + typo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QWxleCBaw7xwa2U=?= , qemu-devel@nongnu.org On 12/12/2014 10:25 AM, Alex Züpke wrote: > Fixes offset masking for BOL opcodes and a typo (LONF -> LONG) > > Signed-off-by: Alex Zuepke Hi Alex, good catch. I wonder how that slipped through my testsuit. However you mail seems to be malformed. The patch went somehow into your signature. Don't do that, please. It is easier for the reviewer and you, if he can inline comments to the corresponding line, he wants to talk about. Also you don't need a v1 for the first version of a patch and please group up similar patches, e.g. for tricore. The usual workflow with git would be, for your two patches: 1) git format-patch -2 --cover-letter 2) edit coverletter and say, what the patches are doing. 3) git send-email --to="qemu-devel@nongnu.org" --cc=... *.patch Other than that, it looks good to me. If you resend your two patches well formated, I'll add them to my tricore-next branch. Cheers, Bastian