From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzQVZ-0003qN-TY for qemu-devel@nongnu.org; Fri, 12 Dec 2014 08:43:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzQVV-0005SV-3i for qemu-devel@nongnu.org; Fri, 12 Dec 2014 08:43:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzQVU-0005SR-PO for qemu-devel@nongnu.org; Fri, 12 Dec 2014 08:43:44 -0500 Message-ID: <548AF10A.3030407@redhat.com> Date: Fri, 12 Dec 2014 14:43:38 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1418087585-27601-1-git-send-email-lersek@redhat.com> <1418087585-27601-6-git-send-email-lersek@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 5/7] hw/loader: split out load_image_gzipped_buffer() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Andrew Jones , QEMU Developers "Richard W.M. Jones" On 12/12/14 14:11, Peter Maydell wrote: > On 9 December 2014 at 01:13, Laszlo Ersek wrote: >> In the next patch we'd like to reuse the image decompression facility >> without installing the output as a ROM at a specific guest-phys address. >> >> In addition, expose LOAD_IMAGE_MAX_GUNZIP_BYTES, because that's a >> straightforward "max_sz" argument for the new load_image_gzipped_buffer(). >> >> Signed-off-by: Laszlo Ersek >> --- > >> +int load_image_gzipped(const char *filename, hwaddr addr, uint64_t max_sz) >> +{ >> + int bytes; >> + uint8_t *data; >> + >> + bytes = load_image_gzipped_buffer (filename, max_sz, &data); > > Doesn't checkpatch complain about the space before the "(" here? (Checkpatch? What's that? :)) It sure does. WARNING: space prohibited between function name and open parenthesis '(' Obviously, the edk2 coding style *requires* that damn space. I got so used to it that it slipped in here. Thanks! Laszlo > > Otherwise: > Reviewed-by: Peter Maydell > > -- PMM >