From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46533)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Y0DvW-0004LO-5f
	for qemu-devel@nongnu.org; Sun, 14 Dec 2014 13:29:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Y0DvR-0005zF-9k
	for qemu-devel@nongnu.org; Sun, 14 Dec 2014 13:29:54 -0500
Received: from mail-qa0-x236.google.com ([2607:f8b0:400d:c00::236]:52163)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Y0DvR-0005xs-5K
	for qemu-devel@nongnu.org; Sun, 14 Dec 2014 13:29:49 -0500
Received: by mail-qa0-f54.google.com with SMTP id i13so7365659qae.27
	for <qemu-devel@nongnu.org>; Sun, 14 Dec 2014 10:29:48 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <548DD718.1010100@twiddle.net>
Date: Sun, 14 Dec 2014 10:29:44 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1418489298-1184-1-git-send-email-antonynpavlov@gmail.com>
In-Reply-To: <1418489298-1184-1-git-send-email-antonynpavlov@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4] qemu-log: add log category for MMU info
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Antony Pavlov <antonynpavlov@gmail.com>, qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Alexander Graf <agraf@suse.de>, Aurelien Jarno <aurelien@aurel32.net>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>

On 12/13/2014 08:48 AM, Antony Pavlov wrote:
> Running barebox on qemu-system-mips* with '-d unimp' overloads
> stderr by very very many mips_cpu_handle_mmu_fault() messages:
> 
>   mips_cpu_handle_mmu_fault address=b80003fd ret 0 physical 00000000180003fd prot 3
>   mips_cpu_handle_mmu_fault address=a0800884 ret 0 physical 0000000000800884 prot 3
>   mips_cpu_handle_mmu_fault pc a080cd80 ad b80003fd rw 0 mmu_idx 0
> 
> So it's very difficult to find LOG_UNIMP message.
> 
> The mips_cpu_handle_mmu_fault() messages appear on enabling ANY
> logging! It's not very handy.
> 
> Adding separate log category for *_cpu_handle_mmu_fault()
> logging fixes the problem.
> 
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> Acked-by: Alexander Graf <agraf@suse.de>
> ---

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~