From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0RQH-0000mB-5I for qemu-devel@nongnu.org; Mon, 15 Dec 2014 03:54:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0RQC-00015b-LN for qemu-devel@nongnu.org; Mon, 15 Dec 2014 03:54:33 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:34610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0RQB-00012m-8O for qemu-devel@nongnu.org; Mon, 15 Dec 2014 03:54:28 -0500 Message-ID: <548EA19B.7060200@huawei.com> Date: Mon, 15 Dec 2014 16:53:47 +0800 From: "Wangting (Kathy)" MIME-Version: 1.0 References: <1418196538-44904-1-git-send-email-kathy.wangting@huawei.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] NetKVM: fix for indirectc mode when vring is full List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yan Vugenfirer Cc: Dmitry Fleytman , boby.chen@huawei.com, qemu-devel , wu.wubin@huawei.com okay, thank you, I think it is better for net and other feature with one virtio code set like linux. On 2014-12-14 21:30, Yan Vugenfirer wrote: > Thanks! > > The fix is correct, but I am not sure this patch is needed. > This is a frozen part of the code with XP and Windows 2003 support for NetKVM only. > > The library that is used for newer OSes and other drivers has this fix: https://github.com/YanVugenfirer/kvm-guest-drivers-windows/commit/264f1b6c86f5eeca5e2c9fbd24e3de8dbd0bee1d > > In the NetKVM driver code itself we are testing for those conditions before calling to add_buf (check ParaNdis_DoSubmitPacket function in https://github.com/YanVugenfirer/kvm-guest-drivers-windows/blob/stable/NetKVM/NDIS5/Common/ParaNdis-Common.c#L1528). > > Best regads, > Yan. > >> On Dec 10, 2014, at 9:28 AM, Ting Wang wrote: >> >> In function vring_add_indirect, there is no limiti >> about free entry in vring. If vring is full, >> vq->num_free will be less than zero, and >> the address of vq->vring.desc becomes illegal. >> >> Signed-off-by: Ting Wang >> --- >> NetKVM/NDIS5/VirtIO/VirtIORing.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/NetKVM/NDIS5/VirtIO/VirtIORing.c b/NetKVM/NDIS5/VirtIO/VirtIORing.c >> index 90ace4c..0f3783c 100644 >> --- a/NetKVM/NDIS5/VirtIO/VirtIORing.c >> +++ b/NetKVM/NDIS5/VirtIO/VirtIORing.c >> @@ -150,7 +150,7 @@ static int vring_add_buf(struct virtqueue *_vq, >> return -1; >> } >> >> - if (va_indirect) >> + if (va_indirect && (out + in) > 1 && vq->num_free) >> { >> int ret = vring_add_indirect(_vq, sg, out, in, va_indirect, phys_indirect); >> if (ret >= 0) >> -- >> 1.8.5 >> >> > > > . >