From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0XRZ-0003Yx-Tt for qemu-devel@nongnu.org; Mon, 15 Dec 2014 10:20:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0XRP-0006Fj-B9 for qemu-devel@nongnu.org; Mon, 15 Dec 2014 10:20:17 -0500 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]:33840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0XRP-0006Dz-5S for qemu-devel@nongnu.org; Mon, 15 Dec 2014 10:20:07 -0500 Received: by mail-wi0-f174.google.com with SMTP id h11so9223167wiw.7 for ; Mon, 15 Dec 2014 07:20:06 -0800 (PST) Sender: Paolo Bonzini Message-ID: <548EFC21.2070703@redhat.com> Date: Mon, 15 Dec 2014 16:20:01 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1418217570-15517-1-git-send-email-marcel.a@redhat.com> <1418217570-15517-2-git-send-email-marcel.a@redhat.com> <1418274309.15503.47.camel@localhost.localdomain> <548EFA95.3080407@suse.de> In-Reply-To: <548EFA95.3080407@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] machine: remove qemu_machine_opts global list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , Marcel Apfelbaum , Greg Bellows Cc: Peter Maydell , QEMU Developers , mst@redhat.com On 15/12/2014 16:13, Alexander Graf wrote: > MACHINE_OPT(kvm_shadow_mem, "kvm-shadow-mem", "Use KVM in-kernel > irqchip", _bool, NULL); > > Not sure it's a great improvement though. I certainly wouldn't mind to > leave it as this patch does it. I agree. If we want to "hint" that every property should have a description, the QOM functions should have the argument. Paolo