From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0XXq-0000nC-FY for qemu-devel@nongnu.org; Mon, 15 Dec 2014 10:26:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0XXk-0000E3-Ba for qemu-devel@nongnu.org; Mon, 15 Dec 2014 10:26:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0XXk-0000Ds-3i for qemu-devel@nongnu.org; Mon, 15 Dec 2014 10:26:40 -0500 Message-ID: <548EFDA6.3020509@redhat.com> Date: Mon, 15 Dec 2014 16:26:30 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1418388243-1886-1-git-send-email-pbonzini@redhat.com> <1418388243-1886-3-git-send-email-pbonzini@redhat.com> <20141215114018.GC5502@work-vm> <548ECE05.3050009@redhat.com> <20141215152125.GG5502@work-vm> In-Reply-To: <20141215152125.GG5502@work-vm> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 2/4] serial: clean up THRE/TEMT handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: imammedo@redhat.com, andrey@xdel.ru, qemu-devel@nongnu.org, dslutz@verizon.com, batuzovk@ispras.ru On 15/12/2014 16:21, Dr. David Alan Gilbert wrote: >> > >> > - serial_xmit is called from outside only after resetting TEMT and THRE >> > and pushing a character on the FIFO > Are you sure about TEMT? My reading of serial_ioport_write is that if > !FCR_FE then TEMT isn't cleared. This patch changes that. Paolo