From: Paolo Bonzini <pbonzini@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: imammedo@redhat.com, andrey@xdel.ru, qemu-devel@nongnu.org,
batuzovk@ispras.ru
Subject: Re: [Qemu-devel] [PATCH v3 3/4] serial: update LSR on enabling/disabling FIFOs
Date: Mon, 15 Dec 2014 16:52:37 +0100 [thread overview]
Message-ID: <548F03C5.8010008@redhat.com> (raw)
In-Reply-To: <20141215155040.GI5502@work-vm>
On 15/12/2014 16:50, Dr. David Alan Gilbert wrote:
>> >
>> > if (val & UART_FCR_XFR) {
>> > + s->lsr |= UART_LSR_THRE;
>> > + s->thr_ipending = 1;
>> > fifo8_reset(&s->xmit_fifo);
>> > }
> Doesn't that break the assertion you added in patch 2?
> i.e. if I write a character, but it can't be sent, so it's added
> to the tsr_retry, but before the callback I set FCR_XFR, and that
> now sets LSR_THRE, then the callback triggers and it hits the
> assert?
You're right. The TEMT assertion is okay, but the THRE assertion should
be inside if (s->tsr_retry <= 0).
Paolo
next prev parent reply other threads:[~2014-12-15 15:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 12:43 [Qemu-devel] [PATCH v3 0/4] serial fixes, including 2.2->2.1 migration Paolo Bonzini
2014-12-12 12:44 ` [Qemu-devel] [PATCH v3 1/4] serial: reset thri_pending on IER writes with THRI=0 Paolo Bonzini
2014-12-15 10:46 ` Dr. David Alan Gilbert
2014-12-15 11:51 ` Paolo Bonzini
2014-12-15 13:30 ` Dr. David Alan Gilbert
2014-12-15 13:34 ` Paolo Bonzini
2014-12-15 13:37 ` Dr. David Alan Gilbert
2014-12-15 13:45 ` Paolo Bonzini
2014-12-12 12:44 ` [Qemu-devel] [PATCH v3 2/4] serial: clean up THRE/TEMT handling Paolo Bonzini
2014-12-15 11:40 ` Dr. David Alan Gilbert
2014-12-15 12:03 ` Paolo Bonzini
2014-12-15 15:21 ` Dr. David Alan Gilbert
2014-12-15 15:26 ` Paolo Bonzini
2014-12-15 15:29 ` Dr. David Alan Gilbert
2014-12-12 12:44 ` [Qemu-devel] [PATCH v3 3/4] serial: update LSR on enabling/disabling FIFOs Paolo Bonzini
2014-12-15 15:50 ` Dr. David Alan Gilbert
2014-12-15 15:52 ` Paolo Bonzini [this message]
2014-12-12 12:44 ` [Qemu-devel] [PATCH v3 4/4] serial: only resample THR interrupt on rising edge of IER.THRI Paolo Bonzini
2014-12-15 16:05 ` Dr. David Alan Gilbert
2014-12-15 16:10 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548F03C5.8010008@redhat.com \
--to=pbonzini@redhat.com \
--cc=andrey@xdel.ru \
--cc=batuzovk@ispras.ru \
--cc=dgilbert@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).