From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0YPx-0001sC-VC for qemu-devel@nongnu.org; Mon, 15 Dec 2014 11:22:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0YPs-0000Zz-VQ for qemu-devel@nongnu.org; Mon, 15 Dec 2014 11:22:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33751) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0YPs-0000Zi-Nc for qemu-devel@nongnu.org; Mon, 15 Dec 2014 11:22:36 -0500 Message-ID: <548F0AC8.6060202@redhat.com> Date: Mon, 15 Dec 2014 09:22:32 -0700 From: Eric Blake MIME-Version: 1.0 References: <1418204253-5869-1-git-send-email-kraxel@redhat.com> <1418204253-5869-10-git-send-email-kraxel@redhat.com> <54887A35.3070801@redhat.com> <20141211094046.GA23831@redhat.com> <1418297615.1664.36.camel@nilsson.home.kraxel.org> <20141211114710.GE23831@redhat.com> <1418634999.9400.2.camel@nilsson.home.kraxel.org> In-Reply-To: <1418634999.9400.2.camel@nilsson.home.kraxel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="K16k9KBA9CLIQgWsNLxSOGwFaXbcI3SU8" Subject: Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , "Daniel P. Berrange" Cc: Luiz Capitulino , qemu-devel@nongnu.org, Anthony Liguori , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --K16k9KBA9CLIQgWsNLxSOGwFaXbcI3SU8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/15/2014 02:16 AM, Gerd Hoffmann wrote: > Hi, >=20 >>> > >=20 >>> > > So better add a 'vencrypt-subauth' enum with this list? >> >=20 >> > Yeah probably a good idea > How does this look like (incremental fixup attached, docs to be > updated) ? >=20 > +++ b/qapi-schema.json > @@ -785,12 +785,22 @@ > # > # Since: 2.3 > ## > +{ 'enum': 'VncPriAuth', > + 'data': [ 'none', 'vnc', 'ra2', 'ra2ne', 'tight', 'ultra', > + 'tls', 'vencrypt', 'sasl' ] } > +{ 'enum': 'VncVencryptSubAuth', > + 'data': [ 'plain', > + 'tls-none', 'x509-none', > + 'tls-vnc', 'x509-vnc', > + 'tls-plain', 'x509-plain', > + 'tls-sasl', 'x509-sasl' ] } Might be worth separate docs for the enums (we've done it elsewhere). > { 'type': 'VncInfo2', > - 'data': { 'id' : 'str', > - 'server' : ['VncBasicInfo'], > - 'clients' : ['VncClientInfo'], > - 'auth' : 'str', > - '*display' : 'str' } } > + 'data': { 'id' : 'str', > + 'server' : ['VncBasicInfo'], > + 'clients' : ['VncClientInfo'], > + 'auth' : 'VncPriAuth', > + '*vencrypt' : 'VncVencryptSubAuth', > + '*display' : 'str' } } And don't forget docs for 'vencrypt'. But the interface looks fine to me= =2E --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --K16k9KBA9CLIQgWsNLxSOGwFaXbcI3SU8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUjwrIAAoJEKeha0olJ0NqX/gH/AoZv5iKUhJK9u7MGATe3RQk AmaAugH2UsiB2gJrzolENCPMGV4HElPPuIOCOoKSpdVoCC+kfz77XKjLlcAQH/0V aiScn0GjhptMIDdFbRltOBkrDTNaWPRpp4zZeMytc00hngT5ZxCL0k6iCY+3GkAy HjQHR3AawMm2uN5vEXxq5Mr8wbTIgkiN1zBuj2ccXnQoKIER2qVDL4Pk4IveuhbQ GjkOGQckZggoYRVhCkyBqcyhGBt3wokT3lxx8ukoeI38H5SRQem4lGCfn7EeMSDd 7moblPcJ98DULJwkZfc+7UnwG4jvUX5m1tmPzDJiUMUQob3HicnGFfe0motoJ8Q= =4ehq -----END PGP SIGNATURE----- --K16k9KBA9CLIQgWsNLxSOGwFaXbcI3SU8--