From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44507) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0bFy-0003Cb-SD for qemu-devel@nongnu.org; Mon, 15 Dec 2014 14:24:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0bFs-000722-Mz for qemu-devel@nongnu.org; Mon, 15 Dec 2014 14:24:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0bFs-00071q-Fg for qemu-devel@nongnu.org; Mon, 15 Dec 2014 14:24:28 -0500 Message-ID: <548F3565.8020908@redhat.com> Date: Mon, 15 Dec 2014 21:24:21 +0200 From: Marcel Apfelbaum MIME-Version: 1.0 References: <1418217570-15517-1-git-send-email-marcel.a@redhat.com> <1418217570-15517-4-git-send-email-marcel.a@redhat.com> <548EFB32.6010402@suse.de> <20141215152050.GF11566@redhat.com> In-Reply-To: <20141215152050.GF11566@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] vl.c: add HMP help to machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , Alexander Graf Cc: Marcel Apfelbaum , peter.maydell@linaro.org, greg.bellows@linaro.org, qemu-devel@nongnu.org, mst@redhat.com On 12/15/2014 05:20 PM, Daniel P. Berrange wrote: > On Mon, Dec 15, 2014 at 04:16:02PM +0100, Alexander Graf wrote: >> >> On 10.12.14 14:19, Marcel Apfelbaum wrote: >>> The help is based on the actual machine properties >>> exposing only the relevant options. >>> >>> Signed-off-by: Marcel Apfelbaum >> Can libvirt make use of this or would it need QMP based exposure? > Libvirt *never* looks at any -help option anymore. We exclusively use > the QMP query-XXXX commands to discover information about QEMU. So > if its not already possible to query existance of these new machine > properties via QMP, it'll need work. Hi Daniel, I thought we already have something generic that creates temp QOM object, query its properties and then deletes it. Who can answer this question? (I didn't get the chance to work with qmp yet.) Thanks, Marcel > > Regards, > Daniel >