From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40217)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Y0cvb-0001vC-HF
	for qemu-devel@nongnu.org; Mon, 15 Dec 2014 16:11:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Y0cvW-0004xS-9w
	for qemu-devel@nongnu.org; Mon, 15 Dec 2014 16:11:39 -0500
Received: from mail-wg0-x22c.google.com ([2a00:1450:400c:c00::22c]:46485)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Y0cvW-0004xN-3I
	for qemu-devel@nongnu.org; Mon, 15 Dec 2014 16:11:34 -0500
Received: by mail-wg0-f44.google.com with SMTP id b13so15828172wgh.31
	for <qemu-devel@nongnu.org>; Mon, 15 Dec 2014 13:11:33 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <548F4E81.2010205@redhat.com>
Date: Mon, 15 Dec 2014 22:11:29 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1418411751-3614-1-git-send-email-minyard@acm.org>
	<1418411751-3614-17-git-send-email-minyard@acm.org>
In-Reply-To: <1418411751-3614-17-git-send-email-minyard@acm.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 16/16] ipmi: Add a thread to better
	simulate a BMC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: minyard@acm.org, qemu-devel@nongnu.org
Cc: Corey Minyard <cminyard@mvista.com>



On 12/12/2014 20:15, minyard@acm.org wrote:
> +    if (s->threaded_bmc) {
> +        qemu_mutex_init(&s->lock);
> +        qemu_cond_init(&s->waker);
> +        qemu_thread_create(&s->thread, "ipmi-bmc", ipmi_thread, s, 0);
> +    }
> +
> +    if (s->threaded_bmc) {
> +        qemu_mutex_init(&s->lock);
> +        qemu_cond_init(&s->waker);
> +        qemu_thread_create(&s->thread, "ipmi-bmc", ipmi_thread, s, 0);
> +    }
> +

Duplicated bit---probably a rebase hiccup?

Paolo