From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, ming.lei@canonical.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/7] coroutine: optimizations
Date: Mon, 15 Dec 2014 22:35:09 +0100 [thread overview]
Message-ID: <548F540D.6070908@redhat.com> (raw)
In-Reply-To: <5489A243.1020501@kamp.de>
On 11/12/2014 14:55, Peter Lieven wrote:
> On 02.12.2014 12:05, Paolo Bonzini wrote:
>> As discussed in the other thread, this brings speedups from
>> dropping the coroutine mutex (which serializes multiple iothreads,
>> too) and using ELF thread-local storage.
>>
>> The speedup in perf/cost is about 50% (190->125). Windows port tested
>> with tests/test-coroutine.exe under Wine.
>>
>> Paolo
>>
>> v1->v2: include the noinline attribute [many...]
>> do not mention SwitchToFiber [Kevin]
>> rename run_main_iothread_exit -> run_main_thread_exit
>> leave personal opinions out of commit messages :) [Kevin]
>> mention gain from patch 7 [Peter]
>> change "alloc_pool_size +=" to "alloc_pool_size =" [Peter]
>>
>> Paolo Bonzini (7):
>> coroutine-ucontext: use __thread
>> qemu-thread: add per-thread atexit functions
>> test-coroutine: avoid overflow on 32-bit systems
>> QSLIST: add lock-free operations
>> coroutine: rewrite pool to avoid mutex
>> coroutine: drop qemu_coroutine_adjust_pool_size
>> coroutine: try harder not to delete coroutines
>>
>> block/block-backend.c | 4 --
>> coroutine-ucontext.c | 64 +++++++---------------------
>> include/block/coroutine.h | 10 -----
>> include/qemu/queue.h | 15 ++++++-
>> include/qemu/thread.h | 4 ++
>> qemu-coroutine.c | 104
>> ++++++++++++++++++++++------------------------
>> tests/test-coroutine.c | 2 +-
>> util/qemu-thread-posix.c | 37 +++++++++++++++++
>> util/qemu-thread-win32.c | 48 ++++++++++++++++-----
>> 9 files changed, 157 insertions(+), 131 deletions(-)
>>
>
> Whats the status of this series?
Maintainers are probably just waiting for a complete Reviewed-by. If
you can provide performance numbers, that would help too.
Paolo
next prev parent reply other threads:[~2014-12-15 21:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 11:05 [Qemu-devel] [PATCH v2 0/7] coroutine: optimizations Paolo Bonzini
2014-12-02 11:05 ` [Qemu-devel] [PATCH v2 1/7] coroutine-ucontext: use __thread Paolo Bonzini
2014-12-02 11:05 ` [Qemu-devel] [PATCH v2 2/7] qemu-thread: add per-thread atexit functions Paolo Bonzini
2014-12-02 11:05 ` [Qemu-devel] [PATCH v2 3/7] test-coroutine: avoid overflow on 32-bit systems Paolo Bonzini
2014-12-02 11:05 ` [Qemu-devel] [PATCH v2 4/7] QSLIST: add lock-free operations Paolo Bonzini
2014-12-02 11:05 ` [Qemu-devel] [PATCH v2 5/7] coroutine: rewrite pool to avoid mutex Paolo Bonzini
2014-12-02 12:09 ` Peter Lieven
2014-12-02 12:13 ` Paolo Bonzini
2014-12-02 12:18 ` Peter Lieven
2014-12-02 12:32 ` Paolo Bonzini
2014-12-02 13:04 ` Kevin Wolf
2014-12-02 11:05 ` [Qemu-devel] [PATCH v2 6/7] coroutine: drop qemu_coroutine_adjust_pool_size Paolo Bonzini
2014-12-02 11:05 ` [Qemu-devel] [PATCH v2 7/7] coroutine: try harder not to delete coroutines Paolo Bonzini
2014-12-11 13:55 ` [Qemu-devel] [PATCH v2 0/7] coroutine: optimizations Peter Lieven
2014-12-15 21:35 ` Paolo Bonzini [this message]
2014-12-18 10:06 ` Fam Zheng
2015-01-06 15:39 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548F540D.6070908@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=ming.lei@canonical.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).