From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56349) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0gZL-0002za-KC for qemu-devel@nongnu.org; Mon, 15 Dec 2014 20:04:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0gZG-00048n-Gs for qemu-devel@nongnu.org; Mon, 15 Dec 2014 20:04:55 -0500 Received: from cantor2.suse.de ([195.135.220.15]:36901 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0gZG-00048i-AV for qemu-devel@nongnu.org; Mon, 15 Dec 2014 20:04:50 -0500 Message-ID: <548F8531.3030009@suse.de> Date: Tue, 16 Dec 2014 02:04:49 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1418690628-20652-1-git-send-email-david@gibson.dropbear.id.au> <1418690628-20652-5-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1418690628-20652-5-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/5] pseries: Export /machine "rtc-time" property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , aik@ozlabs.ru, mdroth@us.ibm.com Cc: paulus@samba.org, qemu-devel@nongnu.org On 16.12.14 01:43, David Gibson wrote: > On x86, the guest's RTC can be read with QMP via the "rtc-time" property > on the /machine object. This is due to an explicit QOM alias being set up > by the mc146818rtc driver, and doesn't work on other targets. > > This extends the pseries RTAS RTC to populate that property, for improved > management compatibility with x86 guests. > > Signed-off-by: David Gibson Yeah, this really should happen inside an rtc device. > --- > hw/ppc/spapr_rtc.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > > diff --git a/hw/ppc/spapr_rtc.c b/hw/ppc/spapr_rtc.c > index fac0017..13e74f1 100644 > --- a/hw/ppc/spapr_rtc.c > +++ b/hw/ppc/spapr_rtc.c > @@ -28,6 +28,7 @@ > #include "cpu.h" > #include "hw/ppc/spapr.h" > #include "qapi-event.h" > +#include "qapi/visitor.h" > > void spapr_rtc_read(sPAPREnvironment *spapr, struct tm *tm, uint32_t *ns) > { > @@ -87,10 +88,58 @@ static void rtas_set_time_of_day(PowerPCCPU *cpu, sPAPREnvironment *spapr, > rtas_st(rets, 0, RTAS_OUT_SUCCESS); > } > > +static void spapr_qom_rtc_time(Object *obj, Visitor *v, void *opaque, > + const char *name, Error **errp) Also this function is mostly copy&paste from the mc14foo driver. Do you think you can share this somehow? I also think the alias should get created by the machine, not the device itself. Alex