From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46758)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ZKSE4-0003md-FW
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 10:20:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ZKSE0-0002ib-Eg
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 10:20:56 -0400
Received: from mx6-phx2.redhat.com ([209.132.183.39]:39729)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ZKSE0-0002i4-7N
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 10:20:52 -0400
Date: Wed, 29 Jul 2015 10:20:31 -0400 (EDT)
From: Thomas Huth <thuth@redhat.com>
Message-ID: <549013493.403650.1438179631766.JavaMail.zimbra@redhat.com>
In-Reply-To: <55B8DDB2.9080607@cn.fujitsu.com>
References: <1438167116-29270-1-git-send-email-yanghy@cn.fujitsu.com>
	<1438167116-29270-2-git-send-email-yanghy@cn.fujitsu.com>
	<1291287430.378249.1438178034593.JavaMail.zimbra@redhat.com>
	<55B8DDB2.9080607@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/12] net: add a new object netfilter
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yang Hongyang <yanghy@cn.fujitsu.com>
Cc: zhang zhanghailiang <zhang.zhanghailiang@huawei.com>, jasowang@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, stefanha@redhat.com

On Wednesday, July 29, 2015 4:05:38 PM,
"Yang Hongyang" <yanghy@cn.fujitsu.com> wrote:
> 
> On 07/29/2015 09:53 PM, Thomas Huth wrote:
> > On Wednesday, July 29, 2015 12:51:45 PM,
> > "Yang Hongyang" <yanghy@cn.fujitsu.com> wrote:
> >>
> >> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
> >
> > Maybe add at least a very short patch description? You're doing
> > a little bit more than just "add a new object netfilter" as
> > mentioned in the title...
> 
> How about:
> Add a new object netfilter, used to capture packets send/receive
> by network backend, init it after init net clients.

I rather thought about a short remark about the fact that this
patch also adds the "-netfilter" option. So maybe something
like this:

"Add the framework for a new netfilter object and a new
-netfilter CLI option as a basis for the following patches"

?

 Thomas