From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0qkY-000542-MZ for qemu-devel@nongnu.org; Tue, 16 Dec 2014 06:57:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0qkQ-0007mH-UL for qemu-devel@nongnu.org; Tue, 16 Dec 2014 06:57:10 -0500 Received: from cantor2.suse.de ([195.135.220.15]:44704 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0qkQ-0007ll-NO for qemu-devel@nongnu.org; Tue, 16 Dec 2014 06:57:02 -0500 Message-ID: <54901E0A.7000704@suse.de> Date: Tue, 16 Dec 2014 12:56:58 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1418722138-37222-1-git-send-email-blaschka@linux.vnet.ibm.com> <20141216114649.GA53045@tuxmaker.boeblingen.de.ibm.com> In-Reply-To: <20141216114649.GA53045@tuxmaker.boeblingen.de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] s390/pci: fix build on 32-bit and non linux List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Frank Blaschka Cc: "cornelia.huck@de.ibm.com" , "borntraeger@de.ibm.com" , Frank Blaschka , "qemu-devel@nongnu.org" , "peter.maydell@linaro.org" On 16.12.14 12:46, Frank Blaschka wrote: > On Tue, Dec 16, 2014 at 11:35:19AM +0100, Alexander Graf wrote: >> >> >> >>> Am 16.12.2014 um 10:28 schrieb Frank Blaschka : >>> >>> From: Frank Blaschka >>> >>> Remove unnecessary and wrong includes. Fix get_rt_sto and >>> get_st_pto to build on 32-bit. >>> >>> Signed-off-by: Frank Blaschka >> >> Could you please roll the fixes into the offending patches and repost the set? Otherwise we break bisectability on 32bit hosts. >> > > Sure, but since this is an initial drop and I have to touch the patches anyhow can I merge all > add-ons and fixes to the initial patch set? > > I would like to end up finally with just 3 patches: > > s390: Add PCI bus support > s390: implement pci instructions > kvm: extend kvm_irqchip_add_msi_route to work on s390 > > If so I would post V2 of the initial patch set including all changes. Cornelia is the maintainer here, so you'll need to ask her :). Anything that doesn't break bisectability is certainly better than code that breaks it. By squashing all those patches together you'll make bisecting harder for s390 - if you can live with it so can I. Alex