From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44266)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1Y0rV3-0001Cu-D1
	for qemu-devel@nongnu.org; Tue, 16 Dec 2014 07:45:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1Y0rUy-0004ti-F2
	for qemu-devel@nongnu.org; Tue, 16 Dec 2014 07:45:13 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52183)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1Y0rUy-0004sg-6u
	for qemu-devel@nongnu.org; Tue, 16 Dec 2014 07:45:08 -0500
Message-ID: <5490294A.30501@redhat.com>
Date: Tue, 16 Dec 2014 13:44:58 +0100
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1418399932-7658-1-git-send-email-lersek@redhat.com>
	<1418399932-7658-8-git-send-email-lersek@redhat.com>
	<54902260.2060105@suse.de>
	<CAFEAcA_Nhk45bOc6J2-2fhWxO=2XXT4MhEqCOhmmk5698ZGCMA@mail.gmail.com>
	<549023A4.8060106@suse.de>
	<CAFEAcA8e5vA3y_gRCy0HLYzwYzRQyg51B1ZEm_mAyixNWXZHww@mail.gmail.com>
	<20141216124217.GV15695@redhat.com>
In-Reply-To: <20141216124217.GV15695@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 7/8] hw/arm: pass pristine kernel image
 to guest firmware over fw_cfg
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Richard W.M. Jones" <rjones@redhat.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: Andrew Jones <drjones@redhat.com>, Alexander Graf <agraf@suse.de>, QEMU Developers <qemu-devel@nongnu.org>

On 12/16/14 13:42, Richard W.M. Jones wrote:
> On Tue, Dec 16, 2014 at 12:25:41PM +0000, Peter Maydell wrote:
>> On 16 December 2014 at 12:20, Alexander Graf <agraf@suse.de> wrote:
>>> The patch as is assumes that AArch64 images are always gzipped. I don't
>>> think this assumption is correct - if you do "make Image" on a kernel
>>> source tree, you will get an uncompressed Image file.
>>>
>>> I think we'd be better off trying to load it as gzip and if it's not
>>> gzipped, fall back to linear load.
>>
>> Ah, I see what you mean. Yes, we need to continue to support
>> loading non-compressed Images as well as compressed ones,
>> so this patch needs to do the try-and-fall-back, in the
>> same way the current loader code does.
> 
> Hang on, I tested the non-compressed case when I originally submitted
> the patch.
> 
> And indeed it does work (still):

The bug is not in your patch; it's in mine, because it doesn't follow
the fallback behavior that your patch correctly implements.

I guess I'll get to use the get_image_size() / load_image_size()
functions after all...

Thanks
Laszlo