From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0uks-0006U6-GY for qemu-devel@nongnu.org; Tue, 16 Dec 2014 11:13:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0ukn-00013Q-BI for qemu-devel@nongnu.org; Tue, 16 Dec 2014 11:13:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0ukn-00013L-4B for qemu-devel@nongnu.org; Tue, 16 Dec 2014 11:13:41 -0500 Message-ID: <54905A30.9090307@redhat.com> Date: Tue, 16 Dec 2014 09:13:36 -0700 From: Eric Blake MIME-Version: 1.0 References: <1418204253-5869-1-git-send-email-kraxel@redhat.com> <1418204253-5869-10-git-send-email-kraxel@redhat.com> <54887A35.3070801@redhat.com> <20141211094046.GA23831@redhat.com> <1418297615.1664.36.camel@nilsson.home.kraxel.org> <20141211114710.GE23831@redhat.com> <1418634999.9400.2.camel@nilsson.home.kraxel.org> <548F0AC8.6060202@redhat.com> <1418725089.9400.40.camel@nilsson.home.kraxel.org> In-Reply-To: <1418725089.9400.40.camel@nilsson.home.kraxel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LIu2srGpPvMEPqdKHEVpDAVVbRMFvChNk" Subject: Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Luiz Capitulino , qemu-devel@nongnu.org, Anthony Liguori , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LIu2srGpPvMEPqdKHEVpDAVVbRMFvChNk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/16/2014 03:18 AM, Gerd Hoffmann wrote: > Hi, >=20 >>> How does this look like (incremental fixup attached, docs to be >>> updated) ? >=20 >> Might be worth separate docs for the enums (we've done it elsewhere). >=20 > Sure, as mentioned above docs where not done yet ... >=20 >=20 >> But the interface looks fine to me. >=20 > ... as I wanted to check this first ;) >=20 > So, here is the new version with updated docs ;) Looks okay to me on first glance. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LIu2srGpPvMEPqdKHEVpDAVVbRMFvChNk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUkFowAAoJEKeha0olJ0NqfMYH/RE6qCt16SND1bNclIQFCrlt GvbaJE4ggm2+wnW4DprNu/tRhiVwr9wdlaf1rrdFCMcacJFS1WBLnK1crGbNkp6I c9/asATSbuFqvDfKWDYujRk6m8shl3fOIAG3WKj6kdTtTDqESBZXjtWqZOlHlhjA 9NW4wgYxHZpQh1qE1SSZOmn8AkVrsb0jKbYQbj0QpUA9SwGb64lxhG29nUQAdb3i KGUVQ0MfSbMGF1gVyIVLGn9mvSgWkj5ACvTDunIqczNwugF3AhPrEKy7kNZG8Anm GSqD1dS4xhQFBgn7vUUh3yZv3qD9VI3FIWF3ksWENIJWQD3BsJoLY3qJnro3Igw= =yHOX -----END PGP SIGNATURE----- --LIu2srGpPvMEPqdKHEVpDAVVbRMFvChNk--