From: Eric Blake <eblake@redhat.com>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu-devel@nongnu.org
Cc: lilei@linux.vnet.ibm.com, lcapitulino@redhat.com,
lersek@redhat.com, peter.huangpeng@huawei.com,
mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [RFC PATCH 0/2] qga: add guest-get-os-version for windows
Date: Tue, 16 Dec 2014 09:25:34 -0700 [thread overview]
Message-ID: <54905CFE.3070805@redhat.com> (raw)
In-Reply-To: <1418715038-4664-1-git-send-email-zhang.zhanghailiang@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
On 12/16/2014 12:30 AM, zhanghailiang wrote:
> Hi,
>
> This patch series add a new guest command 'guest-get-os-version'.
> It is now only available for windows guest.
Why not also supply it for Linux guests? uname() is your friend; it
should be fairly easy to wire up.
>
> It will return guest's OS version name and type, like bellow:
> '{"return":{"name":"Microsoft Windows Server 2012 R2","type":64}}'
>
> Sometimes we need to know guest's OS version info.
> (Actually, we need this info when we update guest's applications and drivers
> in our project.)
Have you looked into libguestfs' ability to get this information from an
(offline) guest image? I'm not rejecting this command, but trying to
make sure that it is not duplicating something that can already be done.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-12-16 16:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 7:30 [Qemu-devel] [RFC PATCH 0/2] qga: add guest-get-os-version for windows zhanghailiang
2014-12-16 7:30 ` [Qemu-devel] [RFC PATCH 1/2] qga: Introduce guest-get-os-version command with stubs zhanghailiang
2014-12-16 16:23 ` Eric Blake
2015-01-03 0:32 ` Richard W.M. Jones
2014-12-16 7:30 ` [Qemu-devel] [RFC PATCH 2/2] qga: implement qmp_guest_get_os_version for windows zhanghailiang
2014-12-16 11:48 ` Yan Vugenfirer
2014-12-16 16:26 ` Eric Blake
2014-12-17 8:14 ` zhanghailiang
2014-12-16 9:38 ` [Qemu-devel] [RFC PATCH 0/2] qga: add guest-get-os-version " Yan Vugenfirer
2014-12-16 11:06 ` zhanghailiang
2014-12-16 16:25 ` Eric Blake [this message]
2014-12-17 8:12 ` zhanghailiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54905CFE.3070805@redhat.com \
--to=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=lilei@linux.vnet.ibm.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).