From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0uwt-0002gK-6C for qemu-devel@nongnu.org; Tue, 16 Dec 2014 11:26:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0uwo-0005DK-3E for qemu-devel@nongnu.org; Tue, 16 Dec 2014 11:26:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48413) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0uwn-0005DF-R1 for qemu-devel@nongnu.org; Tue, 16 Dec 2014 11:26:06 -0500 Message-ID: <54905CFE.3070805@redhat.com> Date: Tue, 16 Dec 2014 09:25:34 -0700 From: Eric Blake MIME-Version: 1.0 References: <1418715038-4664-1-git-send-email-zhang.zhanghailiang@huawei.com> In-Reply-To: <1418715038-4664-1-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gihXdFPLeSWTpIIHS4OQpBpnWLEIThi7V" Subject: Re: [Qemu-devel] [RFC PATCH 0/2] qga: add guest-get-os-version for windows List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: lilei@linux.vnet.ibm.com, lcapitulino@redhat.com, lersek@redhat.com, peter.huangpeng@huawei.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gihXdFPLeSWTpIIHS4OQpBpnWLEIThi7V Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/16/2014 12:30 AM, zhanghailiang wrote: > Hi, >=20 > This patch series add a new guest command 'guest-get-os-version'. > It is now only available for windows guest. Why not also supply it for Linux guests? uname() is your friend; it should be fairly easy to wire up. >=20 > It will return guest's OS version name and type, like bellow: > '{"return":{"name":"Microsoft Windows Server 2012 R2","type":64}}' >=20 > Sometimes we need to know guest's OS version info. > (Actually, we need this info when we update guest's applications and dr= ivers=20 > in our project.) Have you looked into libguestfs' ability to get this information from an (offline) guest image? I'm not rejecting this command, but trying to make sure that it is not duplicating something that can already be done. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --gihXdFPLeSWTpIIHS4OQpBpnWLEIThi7V Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUkFz/AAoJEKeha0olJ0NqHccH/2YmCKanuwfsqnFvfVqD4qaq fvF8R60Dq1f5Qs2PW4YQEGbUTYcPF6x3mtwo1wtoP18gc3wGHecxzUrfkKo2n712 j6tZvKSPlM8VkulATxyrPtnmOUUcjM7piGfO1QLk7LQ2Hf7iXB19a2ENxboX9ark h6324/qFCkCeWUvJIDfmG3fBlsrKrkUiec/G+6jexgx/FC5IAuGv93z+YcmPARwX UWc+N41i/5DYtU2CkNHxJbxGmWfNZpOH9thWTv40hcinDNg0ZYCfd9p60Sp5GEoT osfkrzvIxuk29rer/tLFlEpO0MZt24wupdUvBawfzHj9Yz3srq/hHm8UCjRvgjM= =CQX+ -----END PGP SIGNATURE----- --gihXdFPLeSWTpIIHS4OQpBpnWLEIThi7V--