From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0uxZ-0003JK-7i for qemu-devel@nongnu.org; Tue, 16 Dec 2014 11:26:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0uxU-0005Lg-AE for qemu-devel@nongnu.org; Tue, 16 Dec 2014 11:26:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55291) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0uxU-0005LN-2O for qemu-devel@nongnu.org; Tue, 16 Dec 2014 11:26:48 -0500 Message-ID: <54905D3E.2010704@redhat.com> Date: Tue, 16 Dec 2014 09:26:38 -0700 From: Eric Blake MIME-Version: 1.0 References: <1418715038-4664-1-git-send-email-zhang.zhanghailiang@huawei.com> <1418715038-4664-3-git-send-email-zhang.zhanghailiang@huawei.com> <2DE29ABD-07C1-4F6B-B826-06FACF87D9F8@redhat.com> In-Reply-To: <2DE29ABD-07C1-4F6B-B826-06FACF87D9F8@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WfmlKTv047m340BJLhWnH3GIcNU1uQbpq" Subject: Re: [Qemu-devel] [RFC PATCH 2/2] qga: implement qmp_guest_get_os_version for windows List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yan Vugenfirer , zhanghailiang Cc: lilei@linux.vnet.ibm.com, qemu-devel , mdroth@linux.vnet.ibm.com, peter.huangpeng@huawei.com, Luiz Capitulino , Laszlo Ersek This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WfmlKTv047m340BJLhWnH3GIcNU1uQbpq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 12/16/2014 04:48 AM, Yan Vugenfirer wrote: >> + >> + if (si.wProcessorArchitecture =3D=3D PROCESSOR_ARCHITECTURE_AMD64= || >> + si.wProcessorArchitecture =3D=3D PROCESSOR_ARCHITECTURE_IA64)= { >=20 > If one of the motivations is to update drivers on the guest - those sho= uld be treated as deferent architectures. > Why not return string as well (x64, x86, IA64, ARM)?=20 The architecture should already be known by the host (after all, the flavor of qemu running the guest should tell you what architecture the guest would report). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --WfmlKTv047m340BJLhWnH3GIcNU1uQbpq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUkF0+AAoJEKeha0olJ0NqoR8IAIarcdzzfH3pmW2bPc/N/YUW EzawK4FLggCefzIt6ZWUDQ0UaqRIWqAavBu8ECnIOzqeBJRu5myid7MYlhAWgxjt xCMrpjXVtpsqn2g8N3LfUKIRYhspBajPa+Xz+uNhEvLBzND1YAJQyHSxs01oC7s0 MKxD6xx9lpXBaDF2qeYDSI8R8ZQQjD65FzwRb1DbbR+/tkIQia7on7Mo0qjNg0VS 7qHPE8c7NPhzsobyNzd2vVC8uBs9xlFSOHkSGS2HTh8+qP8/qe/zyTn36HNx3nZd ZmW9IXm+yhpE7zbzSa1iuE6U2V9f/oOG4dZrZd8AFVp4ju+mLSaM7ekx66FQgpg= =SlkB -----END PGP SIGNATURE----- --WfmlKTv047m340BJLhWnH3GIcNU1uQbpq--