From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41420)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Y15HX-000594-VE
	for qemu-devel@nongnu.org; Tue, 16 Dec 2014 22:28:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Y15HQ-0008HT-Tx
	for qemu-devel@nongnu.org; Tue, 16 Dec 2014 22:28:11 -0500
Received: from szxga01-in.huawei.com ([119.145.14.64]:1128)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1Y15HQ-0008HL-6m
	for qemu-devel@nongnu.org; Tue, 16 Dec 2014 22:28:04 -0500
Message-ID: <5490F832.4080505@huawei.com>
Date: Wed, 17 Dec 2014 11:27:46 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1418721773-29042-1-git-send-email-arei.gonglei@huawei.com>
	<CAFEAcA_eUivaxokNYd1TKuE=goBrydgiCW6FZ-6xJArxUXw3-g@mail.gmail.com>
In-Reply-To: <CAFEAcA_eUivaxokNYd1TKuE=goBrydgiCW6FZ-6xJArxUXw3-g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 0/5] bootdevice patches
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 2014/12/16 22:01, Peter Maydell wrote:

> On 16 December 2014 at 09:22,  <arei.gonglei@huawei.com> wrote:
>> From: root <root@ceth6.(none)>
>>
>> This is my first pull request as a submaintainer. Those patches just
>> move boot order related code to bootdevice.c and add a Error **errp
>> argument for corresponding functions so that it can propagate error messages
>> to the caller. Please pull.
> 
> This also seems to cause 'make check' to fail:
> 
> TEST: tests/boot-order-test... (pid=16958)
>   /i386/boot-order/pc:
> Broken pipe
> FAIL
> GTester: last random seed: R02S5702c094d31af53e45fffabed844705a
> (pid=16973)
> FAIL: tests/boot-order-test
> 

Oops, That's because of a typo in patch 2,  'once' -> 'order'.
 'make check' should be executed before posting patches :(
I apologize for any inconvenience caused during this process,
and great thanks for your precise job.

Regards,
-Gonglei