From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: Eric Blake <eblake@redhat.com>, Yan Vugenfirer <yvugenfi@redhat.com>
Cc: hangaohuai@huawei.com, lilei@linux.vnet.ibm.com,
qemu-devel <qemu-devel@nongnu.org>,
mdroth@linux.vnet.ibm.com,
Luiz Capitulino <lcapitulino@redhat.com>,
peter.huangpeng@huawei.com, Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 2/2] qga: implement qmp_guest_get_os_version for windows
Date: Wed, 17 Dec 2014 16:14:51 +0800 [thread overview]
Message-ID: <54913B7B.6050803@huawei.com> (raw)
In-Reply-To: <54905D3E.2010704@redhat.com>
On 2014/12/17 0:26, Eric Blake wrote:
> On 12/16/2014 04:48 AM, Yan Vugenfirer wrote:
>>> +
>>> + if (si.wProcessorArchitecture == PROCESSOR_ARCHITECTURE_AMD64 ||
>>> + si.wProcessorArchitecture == PROCESSOR_ARCHITECTURE_IA64) {
>>
>> If one of the motivations is to update drivers on the guest - those should be treated as deferent architectures.
>> Why not return string as well (x64, x86, IA64, ARM)?
>
> The architecture should already be known by the host (after all, the
> flavor of qemu running the guest should tell you what architecture the
> guest would report).
>
Yes, we can easily get this info from host ;)
next prev parent reply other threads:[~2014-12-17 8:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 7:30 [Qemu-devel] [RFC PATCH 0/2] qga: add guest-get-os-version for windows zhanghailiang
2014-12-16 7:30 ` [Qemu-devel] [RFC PATCH 1/2] qga: Introduce guest-get-os-version command with stubs zhanghailiang
2014-12-16 16:23 ` Eric Blake
2015-01-03 0:32 ` Richard W.M. Jones
2014-12-16 7:30 ` [Qemu-devel] [RFC PATCH 2/2] qga: implement qmp_guest_get_os_version for windows zhanghailiang
2014-12-16 11:48 ` Yan Vugenfirer
2014-12-16 16:26 ` Eric Blake
2014-12-17 8:14 ` zhanghailiang [this message]
2014-12-16 9:38 ` [Qemu-devel] [RFC PATCH 0/2] qga: add guest-get-os-version " Yan Vugenfirer
2014-12-16 11:06 ` zhanghailiang
2014-12-16 16:25 ` Eric Blake
2014-12-17 8:12 ` zhanghailiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54913B7B.6050803@huawei.com \
--to=zhang.zhanghailiang@huawei.com \
--cc=eblake@redhat.com \
--cc=hangaohuai@huawei.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=lilei@linux.vnet.ibm.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).