* Re: [Qemu-devel] [PATCH] QEMU:Change the IRQ number for GPIO Controller
@ 2014-12-17 9:18 Amit Tomar
2014-12-17 9:21 ` Alexander Graf
0 siblings, 1 reply; 5+ messages in thread
From: Amit Tomar @ 2014-12-17 9:18 UTC (permalink / raw)
To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org; +Cc: agraf@suse.de
Ping :)
-----Original Message-----
From: Tomar Amit-B51888
Sent: Monday, December 08, 2014 3:03 PM
To: 'qemu-devel@nongnu.org'; 'qemu-ppc@nongnu.org'
Cc: 'agraf@suse.de'
Subject: [PATCH] QEMU:Change the IRQ number for GPIO Controller
As per RM and following links IRQ 43 is for I2C controller and IRQ 47 is for GPIO controller.
https://lists.ozlabs.org/pipermail/linuxppc-dev/2011-January/087924.html
http://lxr.free-electrons.com/source/arch/powerpc/boot/dts/fsl/pq3-gpio-0.dtsi?v=3.4
Signed-off-by: Amit Singh Tomar <amit.tomar@freescale.com>
---
hw/ppc/e500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 2832fc0..2cd69a9 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc/e500.c
@@ -65,7 +65,7 @@
#define MPC8544_UTIL_OFFSET 0xe0000ULL
#define MPC8544_SPIN_BASE 0xEF000000ULL
#define MPC8XXX_GPIO_OFFSET 0x000FF000ULL
-#define MPC8XXX_GPIO_IRQ 43
+#define MPC8XXX_GPIO_IRQ 47
struct boot_info
{
--
1.7.9.5
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] QEMU:Change the IRQ number for GPIO Controller
2014-12-17 9:18 [Qemu-devel] [PATCH] QEMU:Change the IRQ number for GPIO Controller Amit Tomar
@ 2014-12-17 9:21 ` Alexander Graf
2014-12-18 14:28 ` [Qemu-devel] [PATCH] hw/ppc/e500.c : Fix GPIO IRQ Number Amit Tomar
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Graf @ 2014-12-17 9:21 UTC (permalink / raw)
To: Amit Tomar, qemu-devel@nongnu.org, qemu-ppc@nongnu.org
On 17.12.14 10:18, Amit Tomar wrote:
> Ping :)
>
> -----Original Message-----
> From: Tomar Amit-B51888
> Sent: Monday, December 08, 2014 3:03 PM
> To: 'qemu-devel@nongnu.org'; 'qemu-ppc@nongnu.org'
> Cc: 'agraf@suse.de'
> Subject: [PATCH] QEMU:Change the IRQ number for GPIO Controller
>
> As per RM and following links IRQ 43 is for I2C controller and IRQ 47 is for GPIO controller.
>
> https://lists.ozlabs.org/pipermail/linuxppc-dev/2011-January/087924.html
> http://lxr.free-electrons.com/source/arch/powerpc/boot/dts/fsl/pq3-gpio-0.dtsi?v=3.4
>
>
> Signed-off-by: Amit Singh Tomar <amit.tomar@freescale.com>
Please change the subject line to something that allows people skimming
through the patches to know that it modifies ppc e500 code.
Otherwise looks good to me.
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [PATCH] hw/ppc/e500.c : Fix GPIO IRQ Number.
2014-12-17 9:21 ` Alexander Graf
@ 2014-12-18 14:28 ` Amit Tomar
2014-12-18 16:48 ` Alexander Graf
0 siblings, 1 reply; 5+ messages in thread
From: Amit Tomar @ 2014-12-18 14:28 UTC (permalink / raw)
To: Alexander Graf, qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Provided appropriate subject line.
Signed-off-by: Amit Singh Tomar <amit.tomar@freescale.com>
---
hw/ppc/e500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 2832fc0..2cd69a9 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc/e500.c
@@ -65,7 +65,7 @@
#define MPC8544_UTIL_OFFSET 0xe0000ULL
#define MPC8544_SPIN_BASE 0xEF000000ULL
#define MPC8XXX_GPIO_OFFSET 0x000FF000ULL
-#define MPC8XXX_GPIO_IRQ 43
+#define MPC8XXX_GPIO_IRQ 47
struct boot_info
{
--
1.7.9.5
-----Original Message-----
From: Alexander Graf [mailto:agraf@suse.de]
Sent: Wednesday, December 17, 2014 2:52 PM
To: Tomar Amit-B51888; qemu-devel@nongnu.org; qemu-ppc@nongnu.org
Subject: Re: [PATCH] QEMU:Change the IRQ number for GPIO Controller
On 17.12.14 10:18, Amit Tomar wrote:
> Ping :)
>
> -----Original Message-----
> From: Tomar Amit-B51888
> Sent: Monday, December 08, 2014 3:03 PM
> To: 'qemu-devel@nongnu.org'; 'qemu-ppc@nongnu.org'
> Cc: 'agraf@suse.de'
> Subject: [PATCH] QEMU:Change the IRQ number for GPIO Controller
>
> As per RM and following links IRQ 43 is for I2C controller and IRQ 47 is for GPIO controller.
>
> https://lists.ozlabs.org/pipermail/linuxppc-dev/2011-January/087924.ht
> ml
> http://lxr.free-electrons.com/source/arch/powerpc/boot/dts/fsl/pq3-gpi
> o-0.dtsi?v=3.4
>
>
> Signed-off-by: Amit Singh Tomar <amit.tomar@freescale.com>
Please change the subject line to something that allows people skimming through the patches to know that it modifies ppc e500 code.
Otherwise looks good to me.
Alex
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] hw/ppc/e500.c : Fix GPIO IRQ Number.
2014-12-18 14:28 ` [Qemu-devel] [PATCH] hw/ppc/e500.c : Fix GPIO IRQ Number Amit Tomar
@ 2014-12-18 16:48 ` Alexander Graf
0 siblings, 0 replies; 5+ messages in thread
From: Alexander Graf @ 2014-12-18 16:48 UTC (permalink / raw)
To: Amit Tomar, qemu-devel@nongnu.org, qemu-ppc@nongnu.org
On 18.12.14 15:28, Amit Tomar wrote:
>
> Provided appropriate subject line.
This time around the patch description is wrong :(. Please just post a
full new patch with a good subject line and a good patch description.
In the git tree, all history from email communication will be gone.
People will only see the subject line, patch description and patch body
that you provide in the latest version of the patch. So please make sure
that this is golden :).
Alex
>
> Signed-off-by: Amit Singh Tomar <amit.tomar@freescale.com>
> ---
> hw/ppc/e500.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 2832fc0..2cd69a9 100644
> --- a/hw/ppc/e500.c
> +++ b/hw/ppc/e500.c
> @@ -65,7 +65,7 @@
> #define MPC8544_UTIL_OFFSET 0xe0000ULL
> #define MPC8544_SPIN_BASE 0xEF000000ULL
> #define MPC8XXX_GPIO_OFFSET 0x000FF000ULL
> -#define MPC8XXX_GPIO_IRQ 43
> +#define MPC8XXX_GPIO_IRQ 47
>
> struct boot_info
> {
> --
> 1.7.9.5
>
>
> -----Original Message-----
> From: Alexander Graf [mailto:agraf@suse.de]
> Sent: Wednesday, December 17, 2014 2:52 PM
> To: Tomar Amit-B51888; qemu-devel@nongnu.org; qemu-ppc@nongnu.org
> Subject: Re: [PATCH] QEMU:Change the IRQ number for GPIO Controller
>
>
> On 17.12.14 10:18, Amit Tomar wrote:
>> Ping :)
>>
>> -----Original Message-----
>> From: Tomar Amit-B51888
>> Sent: Monday, December 08, 2014 3:03 PM
>> To: 'qemu-devel@nongnu.org'; 'qemu-ppc@nongnu.org'
>> Cc: 'agraf@suse.de'
>> Subject: [PATCH] QEMU:Change the IRQ number for GPIO Controller
>>
>> As per RM and following links IRQ 43 is for I2C controller and IRQ 47 is for GPIO controller.
>>
>> https://lists.ozlabs.org/pipermail/linuxppc-dev/2011-January/087924.ht
>> ml
>> http://lxr.free-electrons.com/source/arch/powerpc/boot/dts/fsl/pq3-gpi
>> o-0.dtsi?v=3.4
>>
>>
>> Signed-off-by: Amit Singh Tomar <amit.tomar@freescale.com>
>
> Please change the subject line to something that allows people skimming through the patches to know that it modifies ppc e500 code.
>
> Otherwise looks good to me.
>
> Alex
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [PATCH] QEMU:Change the IRQ number for GPIO Controller
@ 2014-12-08 9:33 Amit Tomar
0 siblings, 0 replies; 5+ messages in thread
From: Amit Tomar @ 2014-12-08 9:33 UTC (permalink / raw)
To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org; +Cc: agraf@suse.de
As per RM and following links IRQ 43 is for I2C controller and IRQ 47 is for GPIO controller.
https://lists.ozlabs.org/pipermail/linuxppc-dev/2011-January/087924.html
http://lxr.free-electrons.com/source/arch/powerpc/boot/dts/fsl/pq3-gpio-0.dtsi?v=3.4
Signed-off-by: Amit Singh Tomar <amit.tomar@freescale.com>
---
hw/ppc/e500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index 2832fc0..2cd69a9 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc/e500.c
@@ -65,7 +65,7 @@
#define MPC8544_UTIL_OFFSET 0xe0000ULL
#define MPC8544_SPIN_BASE 0xEF000000ULL
#define MPC8XXX_GPIO_OFFSET 0x000FF000ULL
-#define MPC8XXX_GPIO_IRQ 43
+#define MPC8XXX_GPIO_IRQ 47
struct boot_info
{
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-12-18 16:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-17 9:18 [Qemu-devel] [PATCH] QEMU:Change the IRQ number for GPIO Controller Amit Tomar
2014-12-17 9:21 ` Alexander Graf
2014-12-18 14:28 ` [Qemu-devel] [PATCH] hw/ppc/e500.c : Fix GPIO IRQ Number Amit Tomar
2014-12-18 16:48 ` Alexander Graf
-- strict thread matches above, loose matches on Subject: below --
2014-12-08 9:33 [Qemu-devel] [PATCH] QEMU:Change the IRQ number for GPIO Controller Amit Tomar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).