From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1B7L-00063r-1q for qemu-devel@nongnu.org; Wed, 17 Dec 2014 04:42:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1B7C-0004Qf-11 for qemu-devel@nongnu.org; Wed, 17 Dec 2014 04:42:02 -0500 Received: from mail-wg0-x22e.google.com ([2a00:1450:400c:c00::22e]:40761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1B7B-0004QY-Qh for qemu-devel@nongnu.org; Wed, 17 Dec 2014 04:41:53 -0500 Received: by mail-wg0-f46.google.com with SMTP id x13so19886024wgg.33 for ; Wed, 17 Dec 2014 01:41:52 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54914FDC.1020708@redhat.com> Date: Wed, 17 Dec 2014 10:41:48 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1418780167-16231-1-git-send-email-jsnow@redhat.com> <1418780167-16231-16-git-send-email-jsnow@redhat.com> In-Reply-To: <1418780167-16231-16-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 15/17] ahci: add support for restarting non-queued commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: kwolf@redhat.com, mreitz@redhat.com, armbru@redhat.com, stefanha@redhat.com, mst@redhat.com On 17/12/2014 02:36, John Snow wrote: > + * If an error was there, ad->busy_slot will not be -1. Restarting > + * the operation will resume execution of the command list, do > + * nothing here. I wrote this comment, and I had to reread it twice to make sense of it. Perhaps: * If an error was there, ad->busy_slot will not be -1. In that * case, restarting the operation will resume execution of the * command list. Otherwise we have to do it here. Paolo