From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35092) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1GkJ-0005jo-LA for qemu-devel@nongnu.org; Wed, 17 Dec 2014 10:42:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1GkE-0006PC-8t for qemu-devel@nongnu.org; Wed, 17 Dec 2014 10:42:39 -0500 Received: from mail-qa0-x232.google.com ([2607:f8b0:400d:c00::232]:37058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1GkE-0006Oa-45 for qemu-devel@nongnu.org; Wed, 17 Dec 2014 10:42:34 -0500 Received: by mail-qa0-f50.google.com with SMTP id dc16so1263376qab.37 for ; Wed, 17 Dec 2014 07:42:32 -0800 (PST) Sender: Richard Henderson Message-ID: <5491A464.3010106@twiddle.net> Date: Wed, 17 Dec 2014 09:42:28 -0600 From: Richard Henderson MIME-Version: 1.0 References: <1418831961-27658-1-git-send-email-kbastian@mail.uni-paderborn.de> <1418831961-27658-2-git-send-email-kbastian@mail.uni-paderborn.de> In-Reply-To: <1418831961-27658-2-git-send-email-kbastian@mail.uni-paderborn.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/8] target-tricore: Change SSOV/SUOV makro name to SSOV32/SUOV32 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bastian Koppelmann , qemu-devel@nongnu.org On 12/17/2014 09:59 AM, Bastian Koppelmann wrote: > Those makros are exclusively used for 32 bit arithmetics and won't work for > 16 bit with two halfwords. So lets get rid of the len parameter and make them > always use 32 bit. Now no token pasting is needed anymore and they can be > regular functions. > > Signed-off-by: Bastian Koppelmann > --- > v1 -> v2: > - SSOV32/SUOV32 are now regular functions. > > target-tricore/op_helper.c | 134 ++++++++++++++++++++------------------------- > 1 file changed, 58 insertions(+), 76 deletions(-) Reviewed-by: Richard Henderson r~