From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1GtU-0005Mv-1x for qemu-devel@nongnu.org; Wed, 17 Dec 2014 10:52:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1GtO-0003Nv-2s for qemu-devel@nongnu.org; Wed, 17 Dec 2014 10:52:07 -0500 Received: from mail-qc0-x22a.google.com ([2607:f8b0:400d:c01::22a]:63173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1GtN-0003No-Vw for qemu-devel@nongnu.org; Wed, 17 Dec 2014 10:52:02 -0500 Received: by mail-qc0-f170.google.com with SMTP id x3so12395202qcv.29 for ; Wed, 17 Dec 2014 07:52:01 -0800 (PST) Sender: Richard Henderson Message-ID: <5491A698.4070608@twiddle.net> Date: Wed, 17 Dec 2014 09:51:52 -0600 From: Richard Henderson MIME-Version: 1.0 References: <1418831961-27658-1-git-send-email-kbastian@mail.uni-paderborn.de> <1418831961-27658-6-git-send-email-kbastian@mail.uni-paderborn.de> In-Reply-To: <1418831961-27658-6-git-send-email-kbastian@mail.uni-paderborn.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 5/8] target-tricore: Add instructions of RR opcode format, that have 0x4b as the first opcode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bastian Koppelmann , qemu-devel@nongnu.org On 12/17/2014 09:59 AM, Bastian Koppelmann wrote: > +/* merge/split/parity */ > +DEF_HELPER_2(bmerge, i32, i32, i32) > +DEF_HELPER_1(bsplit, i64, i32) > +DEF_HELPER_1(parity, i32, i32) > +/* float */ > +DEF_HELPER_1(unpack, i64, i32) > +/* dvinit */ These should be DEF_HELPER_FLAGS. Otherwise, Reviewed-by: Richard Henderson r~