From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1H90-0002Uj-Vz for qemu-devel@nongnu.org; Wed, 17 Dec 2014 11:08:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1H8v-0002WN-V6 for qemu-devel@nongnu.org; Wed, 17 Dec 2014 11:08:10 -0500 Received: from mail-qa0-x232.google.com ([2607:f8b0:400d:c00::232]:51162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1H8v-0002WH-RQ for qemu-devel@nongnu.org; Wed, 17 Dec 2014 11:08:05 -0500 Received: by mail-qa0-f50.google.com with SMTP id dc16so1301884qab.37 for ; Wed, 17 Dec 2014 08:08:05 -0800 (PST) Sender: Richard Henderson Message-ID: <5491AA61.9080508@twiddle.net> Date: Wed, 17 Dec 2014 10:08:01 -0600 From: Richard Henderson MIME-Version: 1.0 References: <1418831961-27658-1-git-send-email-kbastian@mail.uni-paderborn.de> <1418831961-27658-9-git-send-email-kbastian@mail.uni-paderborn.de> In-Reply-To: <1418831961-27658-9-git-send-email-kbastian@mail.uni-paderborn.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 8/8] target-tricore: Add instructions of RR1 opcode format, that have 0xb3 as first opcode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bastian Koppelmann , qemu-devel@nongnu.org On 12/17/2014 09:59 AM, Bastian Koppelmann wrote: > Add instructions of RR1 opcode format, that have 0xb3 as first opcode. > Add helper functions mulh, mulmh and mulrh, that compute multiplication, > with multiprecision (mulmh) or rounding (mulrh) of 4 halfwords, being either low or high parts > of two 32 bit regs. > > Signed-off-by: Bastian Koppelmann > --- > v1 -> v2: > - mul_h/mulm_h/mulr_h: * move arg extraction to tcg-ops. > * compute psw flags in tcg-ops. > * helper now use TCG_CALL_NO_RWG_SE flag. > > target-tricore/helper.h | 4 + > target-tricore/op_helper.c | 72 +++++++++++++++++ > target-tricore/translate.c | 196 +++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 272 insertions(+) Reviewed-by: Richard Henderson r~