From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1Q4t-0003vc-BJ for qemu-devel@nongnu.org; Wed, 17 Dec 2014 20:40:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1Q4n-0001V2-7X for qemu-devel@nongnu.org; Wed, 17 Dec 2014 20:40:31 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1Q4m-0001Uw-Rv for qemu-devel@nongnu.org; Wed, 17 Dec 2014 20:40:25 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBI1eNP0022320 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 17 Dec 2014 20:40:23 -0500 Message-ID: <54923084.8000608@redhat.com> Date: Wed, 17 Dec 2014 20:40:20 -0500 From: John Snow MIME-Version: 1.0 References: <1418780167-16231-1-git-send-email-jsnow@redhat.com> <87wq5q4rck.fsf@blackfin.pond.sub.org> <54914ECF.9070407@redhat.com> In-Reply-To: <54914ECF.9070407@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 00/17] ide: rerror and werror support for IDE and AHCI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Markus Armbruster Cc: kwolf@redhat.com, mreitz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On 12/17/2014 04:37 AM, Paolo Bonzini wrote: > > > On 17/12/2014 09:23, Markus Armbruster wrote: >> I had to read this twice to even guess how this is related to the stated >> subject "ide: rerror and werror support for IDE and AHCI" :) >> >> IDE already supports rerror and werror. I guess this series fixes >> migration bugs that can bite when rerror/werror=stop. Correct? > > IDE over PCI supports rerror and werror. IDE over ISA does not. > > This series makes it possible to support it very easily, see patch 13. > > Paolo > Yes, sorry -- rerror=stop/werror=stop already worked for PCI/BMDMA, but this series as a whole unifies the resume pathways and irons out some migration issues. Most notably, as Paolo states, this fixes ISA and my later patches fix AHCI. AHCI tests are still dependent upon enabling migration, so those aren't here yet, but I sat on this series until I convinced myself that AHCI was working too, hence the delay. The practical upshot is that rerror/werror work for all the acronyms listed using newly unified code pathways. --js