From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1ZAR-0003MU-JR for qemu-devel@nongnu.org; Thu, 18 Dec 2014 06:22:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1ZAL-0005ng-9Q for qemu-devel@nongnu.org; Thu, 18 Dec 2014 06:22:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1ZAL-0005nU-1Y for qemu-devel@nongnu.org; Thu, 18 Dec 2014 06:22:45 -0500 Message-ID: <5492B8FB.3010306@redhat.com> Date: Thu, 18 Dec 2014 12:22:35 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1418850613-26821-1-git-send-email-lersek@redhat.com> In-Reply-To: <1418850613-26821-1-git-send-email-lersek@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 00/11] fw_cfg, bootorder, and UEFI+'-kernel' on arm/virt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek , peter.maydell@linaro.org, qemu-devel@nongnu.org, rjones@redhat.com, drjones@redhat.com, agraf@suse.de On 17/12/2014 22:10, Laszlo Ersek wrote: > Addressing review comments received for v4 (with many thanks). > > Deeper changes in v5 include (see also the notes per patch): > > - The I/O port mapping and the MMIO mapping have been split into > separate QOM subclasses. This is new territory for me (what is not, > heh), so bear with me. > > I've done this because a wide data I/O port didn't seem overly useful, > but marrying it with the overlapped selector/data case was certainly a > huge mess. This is just so much cleaner. (Assuming I got it right.) Pretty much. > - The memory mapped selector and data registers are explicitly big > endian now. > > - The memory mapped data register performs its own value > (de)composition, the memory subsystem is left out from that role. Patches 1-7 Reviewed-by: Paolo Bonzini Paolo