From: Max Reitz <mreitz@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
jsnow@redhat.com, Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 2/4] qmp: Add command 'blockdev-backup'
Date: Thu, 18 Dec 2014 16:02:45 +0100 [thread overview]
Message-ID: <5492EC95.3020907@redhat.com> (raw)
In-Reply-To: <1418899027-8445-3-git-send-email-famz@redhat.com>
On 2014-12-18 at 11:37, Fam Zheng wrote:
> Similar to drive-backup, but this command uses a device id as target
> instead of creating/opening an image file.
>
> Also add blocker on target bs, since the target is also a named device
> now.
>
> Add check and report error for bs == target which became possible but is
> an illegal case with introduction of blockdev-backup.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block/backup.c | 28 +++++++++++++++++++++++++++
> blockdev.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> qapi/block-core.json | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> qmp-commands.hx | 42 ++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 178 insertions(+)
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2014-12-18 15:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 10:37 [Qemu-devel] [PATCH v6 0/4] qmp: Add "blockdev-backup" Fam Zheng
2014-12-18 10:37 ` [Qemu-devel] [PATCH v6 1/4] qapi: Comment version info in TransactionAction Fam Zheng
2014-12-18 14:33 ` Max Reitz
2014-12-18 10:37 ` [Qemu-devel] [PATCH v6 2/4] qmp: Add command 'blockdev-backup' Fam Zheng
2014-12-18 15:02 ` Max Reitz [this message]
2014-12-18 18:07 ` John Snow
2014-12-18 10:37 ` [Qemu-devel] [PATCH v6 3/4] block: Add blockdev-backup to transaction Fam Zheng
2014-12-18 14:44 ` Max Reitz
2014-12-18 10:37 ` [Qemu-devel] [PATCH v6 4/4] qemu-iotests: Test blockdev-backup in 055 Fam Zheng
2014-12-19 8:49 ` [Qemu-devel] [PATCH v6 0/4] qmp: Add "blockdev-backup" Markus Armbruster
2014-12-19 9:50 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5492EC95.3020907@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).