From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38789)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Y1cbT-0000cO-FB
	for qemu-devel@nongnu.org; Thu, 18 Dec 2014 10:03:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Y1cbN-0004ZE-BF
	for qemu-devel@nongnu.org; Thu, 18 Dec 2014 10:02:59 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43835)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1Y1cbN-0004Z6-45
	for qemu-devel@nongnu.org; Thu, 18 Dec 2014 10:02:53 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBIF2pKh031754
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Thu, 18 Dec 2014 10:02:52 -0500
Message-ID: <5492EC95.3020907@redhat.com>
Date: Thu, 18 Dec 2014 16:02:45 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1418899027-8445-1-git-send-email-famz@redhat.com>
	<1418899027-8445-3-git-send-email-famz@redhat.com>
In-Reply-To: <1418899027-8445-3-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 2/4] qmp: Add command 'blockdev-backup'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, jsnow@redhat.com, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

On 2014-12-18 at 11:37, Fam Zheng wrote:
> Similar to drive-backup, but this command uses a device id as target
> instead of creating/opening an image file.
>
> Also add blocker on target bs, since the target is also a named device
> now.
>
> Add check and report error for bs == target which became possible but is
> an illegal case with introduction of blockdev-backup.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>   block/backup.c       | 28 +++++++++++++++++++++++++++
>   blockdev.c           | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>   qapi/block-core.json | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>   qmp-commands.hx      | 42 ++++++++++++++++++++++++++++++++++++++++
>   4 files changed, 178 insertions(+)

Reviewed-by: Max Reitz <mreitz@redhat.com>