From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1fUA-0002Hj-40 for qemu-devel@nongnu.org; Thu, 18 Dec 2014 13:07:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1fU2-000526-7y for qemu-devel@nongnu.org; Thu, 18 Dec 2014 13:07:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1fU2-00051o-0N for qemu-devel@nongnu.org; Thu, 18 Dec 2014 13:07:30 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBII7Sd4025804 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 18 Dec 2014 13:07:29 -0500 Message-ID: <549317DD.1010104@redhat.com> Date: Thu, 18 Dec 2014 13:07:25 -0500 From: John Snow MIME-Version: 1.0 References: <1418899027-8445-1-git-send-email-famz@redhat.com> <1418899027-8445-3-git-send-email-famz@redhat.com> In-Reply-To: <1418899027-8445-3-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 2/4] qmp: Add command 'blockdev-backup' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Markus Armbruster , Stefan Hajnoczi , mreitz@redhat.com On 12/18/2014 05:37 AM, Fam Zheng wrote: > Similar to drive-backup, but this command uses a device id as target > instead of creating/opening an image file. > > Also add blocker on target bs, since the target is also a named device > now. > > Add check and report error for bs == target which became possible but is > an illegal case with introduction of blockdev-backup. > > Signed-off-by: Fam Zheng > --- Reviewed-by: John Snow