From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1toQ-00059H-Cy for qemu-devel@nongnu.org; Fri, 19 Dec 2014 04:25:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1toL-00020d-J8 for qemu-devel@nongnu.org; Fri, 19 Dec 2014 04:25:30 -0500 Received: from lhrrgout.huawei.com ([194.213.3.17]:12619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1toL-0001z8-Ac for qemu-devel@nongnu.org; Fri, 19 Dec 2014 04:25:25 -0500 Message-ID: <5493EEFE.2050704@huawei.com> Date: Fri, 19 Dec 2014 10:25:18 +0100 From: Claudio Fontana MIME-Version: 1.0 References: <1418727524-6790-1-git-send-email-imammedo@redhat.com> <1418727524-6790-4-git-send-email-imammedo@redhat.com> In-Reply-To: <1418727524-6790-4-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V2 3/8] pc: acpi-build: cleanup AcpiPmInfo initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: mst@redhat.com, marcel.a@redhat.com On 16.12.2014 11:58, Igor Mammedov wrote: > zero initialize AcpiPmInfo struct to reduce code bloat > a little bit. > > Signed-off-by: Igor Mammedov > --- > hw/i386/acpi-build.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 1fb92e5..f5ec66a 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -161,6 +161,8 @@ static void acpi_get_pm_info(AcpiPmInfo *pm) > Object *obj = NULL; > QObject *o; > > + memset(pm, 0, sizeof(*pm)); > + > if (piix) { > obj = piix; > } > @@ -173,22 +175,16 @@ static void acpi_get_pm_info(AcpiPmInfo *pm) > o = object_property_get_qobject(obj, ACPI_PM_PROP_S3_DISABLED, NULL); > if (o) { > pm->s3_disabled = qint_get_int(qobject_to_qint(o)); > - } else { > - pm->s3_disabled = false; > } > qobject_decref(o); > o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_DISABLED, NULL); > if (o) { > pm->s4_disabled = qint_get_int(qobject_to_qint(o)); > - } else { > - pm->s4_disabled = false; > } > qobject_decref(o); > o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_VAL, NULL); > if (o) { > pm->s4_val = qint_get_int(qobject_to_qint(o)); > - } else { > - pm->s4_val = false; > } > qobject_decref(o); > > Reviewed-by: Claudio Fontana -- Claudio Fontana Server Virtualization Architect Huawei Technologies Duesseldorf GmbH Riesstraße 25 - 80992 München office: +49 89 158834 4135 mobile: +49 15253060158