From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1uCX-0007DF-Pj for qemu-devel@nongnu.org; Fri, 19 Dec 2014 04:50:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1uCS-0004HW-VR for qemu-devel@nongnu.org; Fri, 19 Dec 2014 04:50:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1uCS-0004HP-Lw for qemu-devel@nongnu.org; Fri, 19 Dec 2014 04:50:20 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBJ9oKB6030990 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 19 Dec 2014 04:50:20 -0500 Message-ID: <5493F4D9.8010802@redhat.com> Date: Fri, 19 Dec 2014 10:50:17 +0100 From: Max Reitz MIME-Version: 1.0 References: <1418899027-8445-1-git-send-email-famz@redhat.com> In-Reply-To: <1418899027-8445-1-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 0/4] qmp: Add "blockdev-backup" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , jsnow@redhat.com, Markus Armbruster , Stefan Hajnoczi On 2014-12-18 at 11:37, Fam Zheng wrote: > v6: Add Eric's rev-by in 1/4. > Address minor comments in 2/4, 3/4. > Add John's rev-by in 3/4. > > v5: Address Max's and Markus' comments: > Split patch 1. (Markus) > Fix typos and pastos. (Markus, Max) > Actually acquire aio context. (Max) > Drop unnecessary initialization of fields in blockdev_backup_prepare. (Max) > Add "sync" in the document example. > Add Max's rev-by in patch 4. > > The existing drive-backup command accepts a target file path, but that > interface provides little flexibility on the properties of target block device, > compared to what is possible with "blockdev-add", "drive_add" or "-drive". > > This is also a building block to allow image fleecing (creating a point in time > snapshot and export with nbd-server-add). > > (For symmetry, blockdev-mirror will be added in a separate series.) > > Fam > > > Fam Zheng (4): > qapi: Comment version info in TransactionAction > qmp: Add command 'blockdev-backup' > block: Add blockdev-backup to transaction > qemu-iotests: Test blockdev-backup in 055 > > block/backup.c | 28 ++++++ > blockdev.c | 133 ++++++++++++++++++++++++++++ > qapi-schema.json | 8 ++ > qapi/block-core.json | 54 ++++++++++++ > qmp-commands.hx | 42 +++++++++ > tests/qemu-iotests/055 | 211 +++++++++++++++++++++++++++++++++++++-------- > tests/qemu-iotests/055.out | 4 +- > 7 files changed, 441 insertions(+), 39 deletions(-) (Trusting Markus to fix QERR_* and non-ERROR_CLASS_GENERIC_ERROR uses in a follow-up) Thanks, applied to my block tree: https://github.com/XanClic/qemu/commits/block