From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1uog-00051c-4A for qemu-devel@nongnu.org; Fri, 19 Dec 2014 05:29:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1uoX-00013J-4G for qemu-devel@nongnu.org; Fri, 19 Dec 2014 05:29:50 -0500 Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:62754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1uoW-00012z-Tw for qemu-devel@nongnu.org; Fri, 19 Dec 2014 05:29:41 -0500 Received: by mail-wg0-f45.google.com with SMTP id b13so919690wgh.4 for ; Fri, 19 Dec 2014 02:29:40 -0800 (PST) Sender: Paolo Bonzini Message-ID: <5493FE0E.6090209@redhat.com> Date: Fri, 19 Dec 2014 11:29:34 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1418963165-498-1-git-send-email-ehabkost@redhat.com> <5493F42B.3080208@suse.de> In-Reply-To: <5493F42B.3080208@suse.de> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 0/2] tcg: Move TCG arch-specific initialization inside TCG code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , Eduardo Habkost , qemu-devel@nongnu.org Cc: rth@twiddle.net On 19/12/2014 10:47, Andreas Färber wrote: > How do you imagine this to work with multiple CPU types? From the looks > of it, this is for the target CPU, not the TCG architecture, so > tcg_arch_init() limits us to one implementation unlike now. > On the other hand it doesn't seem to be a per-CPU, i.e. CPUClass, > initialization either... I think these should go in a separate CPUClass method that is called by tcg_exec_init (only for first_cpu now; later for all CPUs if each CPU gets a separate tcg_ctx). Paolo