From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58066)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Y1ve3-0000qy-Qm
	for qemu-devel@nongnu.org; Fri, 19 Dec 2014 06:23:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Y1vdt-0003vh-RJ
	for qemu-devel@nongnu.org; Fri, 19 Dec 2014 06:22:55 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36305)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Y1vdt-0003uw-JO
	for qemu-devel@nongnu.org; Fri, 19 Dec 2014 06:22:45 -0500
Message-ID: <54940A76.7050802@redhat.com>
Date: Fri, 19 Dec 2014 12:22:30 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1418956884-24022-1-git-send-email-ehabkost@redhat.com>
	<1418956884-24022-6-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1418956884-24022-6-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/8] target-i386: Set APIC ID using
	cpu_index on CONFIG_USER
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Gu Zheng <guz.fnst@cn.fujitsu.com>, Igor Mammedov <imammedo@redhat.com>



On 19/12/2014 03:41, Eduardo Habkost wrote:
> +    object_property_set_int(OBJECT(cpu), CPU(cpu)->cpu_index, "apic-id",
> +                            &error);
> +    if (error) {
> +        goto out;
> +    }
> +

Should this use &error_abort?

Paolo