qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Roy Vardi <royv@ezchip.com>, qemu-devel@nongnu.org
Cc: armbru@redhat.com, stefanha@redhat.com, aliguori@amazon.com,
	lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH] net: Add persistent flag to -net tap option
Date: Fri, 19 Dec 2014 08:29:13 -0700	[thread overview]
Message-ID: <54944449.8060901@redhat.com> (raw)
In-Reply-To: <1418645123-32256-1-git-send-email-royv@ezchip.com>

On 12/15/2014 05:05 AM, Roy Vardi wrote:
> From: Roy Vardi <royv@ezchip.com>
> 
>     Add 'persistent' boolean flag to -net tap option.
>     When set to off - tap interface will be released on shutdown
>     When set to on\not specified - tap interface will remain
> 
>     Running with -net tap,persistent=off will force the tap interface
>     down when qemu goes down, thus ensuring that there're no zombie tap
>     interfaces left
> 
>     This is achieved using another ioctl
> 
>     Note: This commit includes the above support only for linux systems
> 
> Signed-off-by: Roy Vardi <royv@ezchip.com>
> ---

> +++ b/qapi-schema.json
> @@ -2007,6 +2007,8 @@
>  #
>  # @queues: #optional number of queues to be created for multiqueue capable tap
>  #
> +# @persistent: #optional for opening tap in persistent mode

Missing a '(since 2.3)' designator; also might be worth mentioning that
the default is true if omitted.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

  parent reply	other threads:[~2014-12-19 15:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-15 12:05 [Qemu-devel] [PATCH] net: Add persistent flag to -net tap option Roy Vardi
2014-12-19 13:13 ` Stefan Hajnoczi
2014-12-19 13:18   ` Daniel P. Berrange
2014-12-21  7:17   ` Roy Vardi
2015-01-06 11:58     ` Stefan Hajnoczi
2014-12-19 15:29 ` Eric Blake [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-12-21  7:48 Roy Vardi
2014-12-22  6:33 ` Jason Wang
2014-12-23  8:44   ` Roy Vardi
     [not found]     ` <AM2PR02MB0532BC1703B005CE79A141FCAA570@AM2PR02MB0532.eurprd02.prod.outlook .com>
2014-12-23  9:13       ` Jason Wang
2014-12-29  7:38         ` Roy Vardi
2015-01-04  7:28           ` Jason Wang
2015-01-18  9:42             ` Roy Vardi
2015-01-22 15:25 ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54944449.8060901@redhat.com \
    --to=eblake@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=armbru@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=royv@ezchip.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).