qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] PPC: e500: Fix GPIO controller interrupt number
@ 2014-12-19 14:20 Amit Tomar
  2014-12-19 17:29 ` Alexander Graf
  0 siblings, 1 reply; 2+ messages in thread
From: Amit Tomar @ 2014-12-19 14:20 UTC (permalink / raw)
  To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org; +Cc: Alexander Graf

This patch sets the GPIO controller interrupt number to 47,not 43 (and the Device tree agrees).


Signed-off-by: Amit Singh Tomar <amit.tomar@freescale.com>
---
 hw/ppc/e500.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 2832fc0..2cd69a9 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc/e500.c
@@ -65,7 +65,7 @@
 #define MPC8544_UTIL_OFFSET        0xe0000ULL
 #define MPC8544_SPIN_BASE          0xEF000000ULL
 #define MPC8XXX_GPIO_OFFSET        0x000FF000ULL
-#define MPC8XXX_GPIO_IRQ           43
+#define MPC8XXX_GPIO_IRQ           47

 struct boot_info
 {
--
1.7.9.5

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] PPC: e500: Fix GPIO controller interrupt number
  2014-12-19 14:20 [Qemu-devel] [PATCH] PPC: e500: Fix GPIO controller interrupt number Amit Tomar
@ 2014-12-19 17:29 ` Alexander Graf
  0 siblings, 0 replies; 2+ messages in thread
From: Alexander Graf @ 2014-12-19 17:29 UTC (permalink / raw)
  To: Amit Tomar, qemu-devel@nongnu.org, qemu-ppc@nongnu.org



On 19.12.14 15:20, Amit Tomar wrote:
> This patch sets the GPIO controller interrupt number to 47,not 43 (and the Device tree agrees).
> 
> 
> Signed-off-by: Amit Singh Tomar <amit.tomar@freescale.com>

Thanks, applied to ppc-next with modified commit message. Let's try to
improve the patch description next time ;).


Alex

Subject: [PATCH] PPC: e500: Fix GPIO controller interrupt number

The GPIO controller lives at IRQ 47, not 43 on real hardware. This is a
problem
because IRQ 43 is occupied by the I2C controller which we want to implement
next, so we'd have a conflict on that IRQ number.

Move the GPIO controller to IRQ 47 where it belongs.

Signed-off-by: Amit Singh Tomar <amit.tomar@freescale.com>
Signed-off-by: Alexander Graf <agraf@suse.de>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-12-19 17:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-19 14:20 [Qemu-devel] [PATCH] PPC: e500: Fix GPIO controller interrupt number Amit Tomar
2014-12-19 17:29 ` Alexander Graf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).