From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y21pO-00053I-2o for qemu-devel@nongnu.org; Fri, 19 Dec 2014 12:59:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y21pJ-00019m-Bs for qemu-devel@nongnu.org; Fri, 19 Dec 2014 12:59:02 -0500 Received: from mail.uni-paderborn.de ([131.234.142.9]:57434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y21pJ-00018e-55 for qemu-devel@nongnu.org; Fri, 19 Dec 2014 12:58:57 -0500 Message-ID: <5494757F.5090107@mail.uni-paderborn.de> Date: Fri, 19 Dec 2014 18:59:11 +0000 From: Bastian Koppelmann MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] target-tricore: pretty-print register dump and show more status registers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Zuepke , qemu-devel@nongnu.org On 12/19/2014 11:34 AM, Alex Zuepke wrote: > Now using psw_read() to retrieve the status bits correctly. > > Signed-off-by: Alex Zuepke > --- > target-tricore/translate.c | 21 +++++++++++++++------ > 1 file changed, 15 insertions(+), 6 deletions(-) > > diff --git a/target-tricore/translate.c b/target-tricore/translate.c > index e3eeedb..3d87346 100644 > --- a/target-tricore/translate.c > +++ b/target-tricore/translate.c > @@ -85,22 +85,31 @@ void tricore_cpu_dump_state(CPUState *cs, FILE *f, > { > TriCoreCPU *cpu = TRICORE_CPU(cs); > CPUTriCoreState *env = &cpu->env; > + uint32_t psw; > int i; > > - cpu_fprintf(f, "PC=%08x\n", env->PC); > + psw = psw_read(env); > + > + cpu_fprintf(f, "PC: " TARGET_FMT_lx, env->PC); > + cpu_fprintf(f, " PSW: " TARGET_FMT_lx, psw); > + cpu_fprintf(f, " ICR: " TARGET_FMT_lx, env->ICR); > + cpu_fprintf(f, "\nPCXI: " TARGET_FMT_lx, env->PCXI); > + cpu_fprintf(f, " FCX: " TARGET_FMT_lx, env->FCX); > + cpu_fprintf(f, " LCX: " TARGET_FMT_lx, env->LCX); > + > for (i = 0; i < 16; ++i) { > if ((i & 3) == 0) { > - cpu_fprintf(f, "GPR A%02d:", i); > + cpu_fprintf(f, "\nGPR A%02d:", i); > } > - cpu_fprintf(f, " %s " TARGET_FMT_lx, regnames_a[i], env->gpr_a[i]); > + cpu_fprintf(f, " " TARGET_FMT_lx, env->gpr_a[i]); > } > for (i = 0; i < 16; ++i) { > if ((i & 3) == 0) { > - cpu_fprintf(f, "GPR D%02d:", i); > + cpu_fprintf(f, "\nGPR D%02d:", i); > } > - cpu_fprintf(f, " %s " TARGET_FMT_lx, regnames_d[i], env->gpr_d[i]); > + cpu_fprintf(f, " " TARGET_FMT_lx, env->gpr_d[i]); > } > - > + cpu_fprintf(f, "\n"); > } > > /* Hi Alex, thanks for the patch. Please, whenever you send a new version of a patch, send the complete series again even if you only changed one patch. Other than that, Reviewed-by: Bastian Koppelmann and applied all the patches to tricore-next. Cheers, Bastian