From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y28ye-0000DK-W1 for qemu-devel@nongnu.org; Fri, 19 Dec 2014 20:37:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y28yY-0001cK-R8 for qemu-devel@nongnu.org; Fri, 19 Dec 2014 20:37:04 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:18107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y28yY-0001Ya-8Z for qemu-devel@nongnu.org; Fri, 19 Dec 2014 20:36:58 -0500 Message-ID: <5494D292.9080007@huawei.com> Date: Sat, 20 Dec 2014 09:36:18 +0800 From: Gonglei MIME-Version: 1.0 References: <1418813672-14768-1-git-send-email-arei.gonglei@huawei.com> <87sigbv9ci.fsf@blackfin.pond.sub.org> In-Reply-To: <87sigbv9ci.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset="GB2312" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/5] bootdevice: Refactor and improvement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: "peter.maydell@linaro.org" , "Huangpeng (Peter)" , "pbonzini@redhat.com" , "qemu-devel@nongnu.org" , "mst@redhat.com" On 2014/12/20 1:27, Markus Armbruster wrote: > I don't understand why you move declarations to sysemu.h, and I had a > few remarks here and there. But I couldn't see anything wrong, so: > My thought is just moving the code related boot order to a unified place. :( > Series > Reviewed-by: Markus Armbruster Thanks for your review. Regards, -Gonglei