From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y2QN3-00036w-NG for qemu-devel@nongnu.org; Sat, 20 Dec 2014 15:11:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y2QMx-000279-IW for qemu-devel@nongnu.org; Sat, 20 Dec 2014 15:11:25 -0500 Received: from mail.uni-paderborn.de ([131.234.142.9]:43010) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y2QMx-00026k-Bq for qemu-devel@nongnu.org; Sat, 20 Dec 2014 15:11:19 -0500 Message-ID: <5495E607.3040606@mail.uni-paderborn.de> Date: Sat, 20 Dec 2014 21:11:35 +0000 From: Bastian Koppelmann MIME-Version: 1.0 References: <1418833065-2109-1-git-send-email-kbastian@mail.uni-paderborn.de> <54949582.8080703@twiddle.net> In-Reply-To: <54949582.8080703@twiddle.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-s390x: Add Extract PSW instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: agraf@suse.de On 12/19/2014 09:15 PM, Richard Henderson wrote: > On 12/17/2014 10:17 AM, Bastian Koppelmann wrote: >> + tcg_gen_andi_tl(regs[r1], regs[r1], ~0xffffffffull); >> + tcg_gen_or_tl(regs[r1], regs[r1], tmp); > This is store_reg32_i64. > > But just reminds me that I've got patches for 8 missing insns > outstanding since September 2013, that got stalled on the > representation of facilities for use by STFLE. > > I should resurrect those... I'm a little bit confused now. Does that mean you already implemented the extract psw instruction in your patches you want to resurrect? However, feel free to cc me when you send those patches, I'd be happy to review them. Cheers, Bastian