From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y307t-0006KN-FO for qemu-devel@nongnu.org; Mon, 22 Dec 2014 05:22:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y307o-0001TN-I6 for qemu-devel@nongnu.org; Mon, 22 Dec 2014 05:22:09 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:8463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y307n-0001T4-S3 for qemu-devel@nongnu.org; Mon, 22 Dec 2014 05:22:04 -0500 Message-ID: <5497F0BA.4010601@huawei.com> Date: Mon, 22 Dec 2014 18:21:46 +0800 From: zhanghailiang MIME-Version: 1.0 References: <1417849159-6568-1-git-send-email-zhang.zhanghailiang@huawei.com> <1417849159-6568-6-git-send-email-zhang.zhanghailiang@huawei.com> <20141221214144.15420.81128@loki> In-Reply-To: <20141221214144.15420.81128@loki> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC for-2.3 5/6] qga: implement qmp_guest_get_memory_block_size() for Linux with sysfs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , qemu-devel@nongnu.org Cc: hangaohuai@huawei.com, peter.huangpeng@huawei.com On 2014/12/22 5:41, Michael Roth wrote: > Quoting zhanghailiang (2014-12-06 00:59:18) >> The size of a memory block is architecture dependent, >> For example, power uses 16MiB, ia64 uses 1GiB, x86 uses 128M. > > That's the minimum for Power, but the size can be set via device tree and > can differ from one platform to the next. > > Should either clarify in the commit or maybe just drop the statement to > avoid confusion. > OK, i will drop that statement. >> It represents the logical unit upon which memory online/offline operations are >> to be performed. >> >> This function will return the value to host user. >> >> Signed-off-by: zhanghailiang >> --- >> qga/commands-posix.c | 43 +++++++++++++++++++++++++++++++++++++------ >> 1 file changed, 37 insertions(+), 6 deletions(-) >> >> diff --git a/qga/commands-posix.c b/qga/commands-posix.c >> index 1010e86..02c6b44 100644 >> --- a/qga/commands-posix.c >> +++ b/qga/commands-posix.c >> @@ -2087,6 +2087,37 @@ int64_t qmp_guest_set_memory_blocks(GuestMemoryBlockList *mem_blks, >> return processed; >> } >> >> +int64_t qmp_guest_get_memory_block_size(Error **errp) >> +{ >> + Error *local_err = NULL; >> + char *dirpath; >> + int dirfd; >> + char *buf; >> + int64_t block_size; >> + >> + dirpath = g_strdup_printf("/sys/devices/system/memory/"); >> + dirfd = open(dirpath, O_RDONLY | O_DIRECTORY); >> + if (dirfd == -1) { >> + error_setg_errno(errp, errno, "open(\"%s\")", dirpath); >> + g_free(dirpath); >> + return -1; >> + } >> + g_free(dirpath); >> + >> + buf = g_malloc0(20); >> + ga_read_sysfs_file(dirfd, "block_size_bytes", buf, 20, &local_err); >> + if (local_err) { >> + g_free(buf); >> + error_propagate(errp, local_err); >> + return -1; >> + } >> + >> + block_size = strtol(buf, NULL, 16); /* the unit is bytes */ >> + g_free(buf); >> + >> + return block_size; >> +} >> + >> #else /* defined(__linux__) */ >> >> void qmp_guest_suspend_disk(Error **errp) >> @@ -2135,6 +2166,12 @@ int64_t qmp_guest_set_memory_blocks(GuestMemoryBlockList *mem_blks, >> return -1; >> } >> >> +int64_t qmp_guest_get_memory_block_size(Error **errp) >> +{ >> + error_set(errp, QERR_UNSUPPORTED); >> + return -1; >> +} >> + >> #endif >> >> #if !defined(CONFIG_FSFREEZE) >> @@ -2221,12 +2258,6 @@ GList *ga_command_blacklist_init(GList *blacklist) >> return blacklist; >> } >> >> -int64_t qmp_guest_get_memory_block_size(Error **errp) >> -{ >> - error_set(errp, QERR_UNSUPPORTED); >> - return -1; >> -} >> - > > Same as with above 2 patches, please squash into the initial stub patch > OK. >> /* register init/cleanup routines for stateful command groups */ >> void ga_command_state_init(GAState *s, GACommandState *cs) >> { >> -- >> 1.7.12.4 > > > . >