From: Alexander Graf <agraf@suse.de>
To: David Gibson <david@gibson.dropbear.id.au>,
aik@ozlabs.ru, mdroth@us.ibm.com
Cc: amit.shah@redhat.com, pbonzini@redhat.com, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2 0/8] pseries: Fix and extend PAPR RTC implementation
Date: Tue, 23 Dec 2014 01:31:43 +0100 [thread overview]
Message-ID: <5498B7EF.7060808@suse.de> (raw)
In-Reply-To: <1419293824-2654-1-git-send-email-david@gibson.dropbear.id.au>
On 23.12.14 01:16, David Gibson wrote:
> At the moment, the PAPR RTC implementation (actually a paravirt
> firmware interface, rather than a normal device) works directly off
> host time, and so doesn't respect the options such as clock=vm which
> can be specified in the -rtc command line option.
>
> Extending the PAPR RTC in this way makes it clearer it should probably
> be its own separate qdev, so this series also implements that.
>
> Finally it moves the code from mc146818rtc for publishing the RTC time
> via QOM into generic QOM helpers, and extends the PAPR RTC driver to
> export in a similar way.
>
> I've done some basic sanity testing on this, but not much. In
> particular I haven't tested the migration code much yet, so that might
> need revision still.
I think we're on the right track. After this patch set, I would like to
see no exported functions related to RTC in include/hw/ppc/spapr.h left
though :). I'm fairly sure you can get all of them handled via qom
properties instead.
Alex
prev parent reply other threads:[~2014-12-23 0:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 0:16 [Qemu-devel] [PATCHv2 0/8] pseries: Fix and extend PAPR RTC implementation David Gibson
2014-12-23 0:16 ` [Qemu-devel] [PATCHv2 1/8] pseries: Move sPAPR RTC code into its own file David Gibson
2014-12-23 0:16 ` [Qemu-devel] [PATCHv2 2/8] pseries: Add more parameter validation in RTAS time of day functions David Gibson
2014-12-23 0:16 ` [Qemu-devel] [PATCHv2 3/8] pseries: Add spapr_rtc_read() helper function David Gibson
2014-12-23 0:17 ` [Qemu-devel] [PATCHv2 4/8] Generalize QOM publishing of date and time from mc146818rtc.c David Gibson
2014-12-23 0:17 ` [Qemu-devel] [PATCHv2 5/8] pseries: Make RTAS time of day functions respect -rtc options David Gibson
2014-12-23 0:17 ` [Qemu-devel] [PATCHv2 6/8] pseries: Make the PAPR RTC a qdev device David Gibson
2014-12-23 0:17 ` [Qemu-devel] [PATCHv2 7/8] pseries: Move rtc_offset into RTC device's state structure David Gibson
2014-12-23 0:30 ` Alexander Graf
2014-12-23 3:56 ` David Gibson
2014-12-23 6:41 ` Alexander Graf
2015-01-28 5:31 ` David Gibson
2014-12-23 0:17 ` [Qemu-devel] [PATCHv2 8/8] pseries: Export RTC time via QOM David Gibson
2014-12-23 0:26 ` Alexander Graf
2014-12-23 3:14 ` David Gibson
2014-12-23 6:33 ` Alexander Graf
2015-01-28 5:28 ` David Gibson
2014-12-23 0:31 ` Alexander Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5498B7EF.7060808@suse.de \
--to=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=amit.shah@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=mdroth@us.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).