From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46117)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1Y3DOC-0003xb-Fm
	for qemu-devel@nongnu.org; Mon, 22 Dec 2014 19:32:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1Y3DO4-0004c1-Ve
	for qemu-devel@nongnu.org; Mon, 22 Dec 2014 19:31:52 -0500
Message-ID: <5498B7EF.7060808@suse.de>
Date: Tue, 23 Dec 2014 01:31:43 +0100
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1419293824-2654-1-git-send-email-david@gibson.dropbear.id.au>
In-Reply-To: <1419293824-2654-1-git-send-email-david@gibson.dropbear.id.au>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv2 0/8] pseries: Fix and extend PAPR RTC
	implementation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>, aik@ozlabs.ru, mdroth@us.ibm.com
Cc: amit.shah@redhat.com, pbonzini@redhat.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org



On 23.12.14 01:16, David Gibson wrote:
> At the moment, the PAPR RTC implementation (actually a paravirt
> firmware interface, rather than a normal device) works directly off
> host time, and so doesn't respect the options such as clock=vm which
> can be specified in the -rtc command line option.
> 
> Extending the PAPR RTC in this way makes it clearer it should probably
> be its own separate qdev, so this series also implements that.
> 
> Finally it moves the code from mc146818rtc for publishing the RTC time
> via QOM into generic QOM helpers, and extends the PAPR RTC driver to
> export in a similar way.
> 
> I've done some basic sanity testing on this, but not much.  In
> particular I haven't tested the migration code much yet, so that might
> need revision still.

I think we're on the right track. After this patch set, I would like to
see no exported functions related to RTC in include/hw/ppc/spapr.h left
though :). I'm fairly sure you can get all of them handled via qom
properties instead.


Alex